Skip to content

Trim go.mod #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Trim go.mod #391

merged 1 commit into from
Nov 26, 2019

Conversation

xueweiz
Copy link
Contributor

@xueweiz xueweiz commented Nov 26, 2019

This is done via running GO111MODULE=on go mod tidy.

This is for #364 .

This is done via running `GO111MODULE=on go mod tidy`.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2019
@xueweiz xueweiz mentioned this pull request Nov 26, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Nov 26, 2019

/cc @grosser

@k8s-ci-robot
Copy link
Contributor

@xueweiz: GitHub didn't allow me to request PR reviews from the following users: grosser.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @grosser

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [wangzhen127,xueweiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ef30a1f into kubernetes:master Nov 26, 2019
@grosser
Copy link
Contributor

grosser commented Nov 26, 2019

that needs to be part of CI or it will just come back ... GO111MODULE=on go mod tidy && git diff --exit-status

@xueweiz
Copy link
Contributor Author

xueweiz commented Nov 26, 2019

Hi @grosser , unfortunately "go mod tidy" always return 0 :)

And also I don't think it's a good idea to do this as part of CI, mainly due to the complicity of the build tags. I commented the reasoning here. Please let me know what you think under #364 . Thanks! :)

@grosser
Copy link
Contributor

grosser commented Nov 26, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants