bump to go1.12.9 #5128
bump to go1.12.9 #5128
Conversation
Signed-off-by: William Zhang <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: warmchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
/assign @afbjorklund |
| @@ -23,7 +23,7 @@ VERSION ?= v$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD) | |||
| DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD) | |||
| RPM_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD) | |||
| # used by hack/jenkins/release_build_and_upload.sh and KVM_BUILD_IMAGE, see also BUILD_IMAGE below | |||
| GO_VERSION ?= 1.12.8 | |||
There was a problem hiding this comment.
we can't use version 1.12.9 yet since the kube-cross image is not available in that version yet.
There was a problem hiding this comment.
k8s.gcr.io/kube-cross:v1.12.9-1 has been released 3 days ago, and upstream K/K repo has switched to this version.
https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/kube-cross?gcrImageListsize=30
There was a problem hiding this comment.
Image downloaded fine here.
There was a problem hiding this comment.
ok ! then I am fine with this change then
|
@minikube-bot OK to test |
Bump to go1.12.9, a small patch on PR5095
ref:
#5087 (comment)
#5087 (comment)