Can't compile release 3.0.0 beta-0

[felipejfc]

We're seeing multiple errors, like:

# github.com/topfreegames/maestro/vendor/k8s.io/client-go/pkg/api/v1
models/vendor/k8s.io/client-go/pkg/api/v1/meta.go:24: cannot use obj (type *ObjectMeta) as type v1.Object in return argument:
	*ObjectMeta does not implement v1.Object (missing GetDeletionGracePeriodSeconds method)

[JuJu227]

The generals/commons (meta and types) has been exacted out and moved to https://github.com/kubernetes/apimachinery. So, you will need to vendor that package and do something similar to import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1". Also worth noting that several of the method signatures have changed, they're basically now requiring additional metadata parameters.

[felipejfc]

@cscatolini, can you try it and see if using apimachinery works?

[ericchiang]

@felipejfc how are you vendoring client-go? client-go generally requires you vendor specific versions of packages it imports, like apimachinery. Are you using any of the instructions here? https://github.com/kubernetes/client-go/blob/master/INSTALL.md

[cscatolini]

@JuJu227, @ericchiang thanks for your help. Following both your instructions I was able to make it compile pointing both to the master branch:

dep ensure k8s.io/client-go@master
dep ensure k8s.io/apimachinery@master

When I try with v3.0.0-beta.0 client-go is installed correctly but apimachinery produces the following output:

 ❯ dep ensure k8s.io/apimachinery@v3.0.0-beta.0
solve error: No versions of k8s.io/apimachinery met constraints:
	master: Could not introduce k8s.io/apimachinery@master, as it is not allowed by constraint v3.0.0-beta.0 from project github.com/topfreegames/maestro.
	release-1.6: Could not introduce k8s.io/apimachinery@release-1.6, as it is not allowed by constraint v3.0.0-beta.0 from project github.com/topfreegames/maestro.
ensure Solve(): No versions of k8s.io/apimachinery met constraints:
	master: Could not introduce k8s.io/apimachinery@master, as it is not allowed by constraint v3.0.0-beta.0 from project github.com/topfreegames/maestro.
	release-1.6: Could not introduce k8s.io/apimachinery@release-1.6, as it is not allowed by constraint v3.0.0-beta.0 from project github.com/topfreegames/maestro.

I checked the repo and there is no tag v3.0.0-beta.0 for apimachinery. In this case how can I know which versions are compatible? I also tried pointing client-go to v3.0.0-beta.0 and apimachinery to master and the compilation errors persist, so I assume they are not compatible.

Edit: reading some other issues I found out that the compatible apimachinery version can be found in this file: https://github.com/kubernetes/client-go/blob/v3.0.0-beta.0/Godeps/Godeps.json so I was able to make it compile with

dep ensure k8s.io/client-go@v3.0.0-beta.0
dep ensure k8s.io/apimachinery@75b8dd260ef0469d96d578705a87cffd0e09dab8

The installation reference it not very clear about the dependencies. Do you think this is worth clarifying? If so, I could send you a PR.

[ericchiang]

The installation reference it not very clear about the dependencies. Do you think this is worth clarifying? If so, I could send you a PR.

I was hoping that dep would automatically detect the version of transitive dependencies from Godeps.json like glide does. This seems like an issue. Does dep look for a manifests file in the packages you ensure? Could we publish that format too?

[caesarxuchao]

dep is not stable, e.g., it recently changed from json to toml for the manifest. I think we shouldn't commit its manifests, as suggested by dep.

I'll send a PR to add an entry for using dep with v3.0.0-beta.0.

[caesarxuchao]

Looks like dep needs some time to support manifests generated by other tools: golang/dep#222

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close