-
Notifications
You must be signed in to change notification settings - Fork 542
Add 307 / 308 Redirect Status Code Support #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidwin93 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @davidwin93! |
Hi @davidwin93. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Dave Winiarski <[email protected]>
40c5a81
to
febeeba
Compare
Thanks @davidwin93, this will be a great improvement! /ok-to-test |
d3b8bad
to
22fe26d
Compare
Signed-off-by: Dave Winiarski <[email protected]>
22fe26d
to
b5bf3dc
Compare
/cc |
What type of PR is this?
/kind bug
/area conformance-test
What this PR does / why we need it:
This PR allows users to select either a 307 or 308 status code along with the existing options of 301 and 302. This matches RFC 9110 and by letting users select 308 it will match the existing nginx ingress behaviour of using a 308 for HTTP -> HTTPS redirects.
Which issue(s) this PR fixes:
Fixes #2748
Does this PR introduce a user-facing change?:
This will allow users to select 307 or 308 as redirect status codes along with 301 and 302.