review comments

Signed-off-by: Sunjay Bhatia <[email protected]>

Author: sunjayBhatia

apis/v1beta1/httproute_types.go

@@ -201,9 +201,10 @@ type HTTPRouteRule struct {
 	// All filters are expected to be compatible with each other except for the
 	// URLRewrite and RequestRedirect filters, which may not be combined. If an
 	// implementation can not support other combinations of filters, they must clearly
-	// document that limitation. In all cases where incompatible or unsupported
-	// filters are specified, implementations MUST add the `PartiallyInvalid` error
-	// condition with status `True` and reason `IncompatibleFilters`.
+	// document that limitation. In cases where incompatible or unsupported
+	// filters are specified on subset of the rules on a route, implementations
+	// MUST add the `PartiallyInvalid` error condition with status `True` and
+	// reason `IncompatibleFilters`.
 	//
 	// Support: Core
 	//

apis/v1beta1/shared_types.go

@@ -298,6 +298,8 @@ const (
 	// Possible reasons for this condition to be true are:
 	//
 	// * "IncompatibleFilters"
+	// * "RefNotPermitted"
+	// * "UnsupportedValue"
 	//
 	// This condition is an error condition and should not be set with status
 	// false.