Skip to content

Commit c6a6e42

Browse files
committed
apply review's suggestion
1 parent bbb49c6 commit c6a6e42

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

config/charts/inferencepool/templates/epp-deployment.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ spec:
111111
- name: OTEL_SERVICE_NAME
112112
value: "gateway-api-inference-extension"
113113
- name: OTEL_EXPORTER_OTLP_ENDPOINT
114-
value: {{ .Values.inferenceExtension.tracing.otelExporterEndpoint | default "http://localhost:4317" | quote }}
114+
value: {{ .Values.inferenceExtension.tracing.otelExporterEndpoint | quote }}
115115
- name: OTEL_TRACES_EXPORTER
116116
value: "otlp"
117117
- name: OTEL_RESOURCE_ATTRIBUTES_NODE_NAME
@@ -127,9 +127,9 @@ spec:
127127
- name: OTEL_RESOURCE_ATTRIBUTES
128128
value: 'k8s.namespace.name=$(NAMESPACE),k8s.node.name=$(OTEL_RESOURCE_ATTRIBUTES_NODE_NAME),k8s.pod.name=$(OTEL_RESOURCE_ATTRIBUTES_POD_NAME)'
129129
- name: OTEL_TRACES_SAMPLER
130-
value: {{ .Values.inferenceExtension.tracing.sampling.sampler | default "parentbased_traceidratio" | quote }}
130+
value: {{ .Values.inferenceExtension.tracing.sampling.sampler | quote }}
131131
- name: OTEL_TRACES_SAMPLER_ARG
132-
value: {{ .Values.inferenceExtension.tracing.sampling.samplerArg | default "0.1" | quote }}
132+
value: {{ .Values.inferenceExtension.tracing.sampling.samplerArg | quote }}
133133
{{- end }}
134134
{{- if .Values.inferenceExtension.env }}
135135
{{- toYaml .Values.inferenceExtension.env | nindent 8 }}

0 commit comments

Comments
 (0)