chore: remove unneeded logging before returning err

Author: phuhung273

cmd/bbr/main.go

@@ -78,7 +78,6 @@ func run() error {
 	// Init runtime.
 	cfg, err := ctrl.GetConfig()
 	if err != nil {
-		setupLog.Error(err, "Failed to get rest config")
 		return err
 	}
 
@@ -111,14 +110,12 @@ func run() error {
 
 	// Register ext-proc server.
 	if err := mgr.Add(serverRunner.AsRunnable(ctrl.Log.WithName("ext-proc"))); err != nil {
-		setupLog.Error(err, "Failed to register ext-proc gRPC server")
 		return err
 	}
 
 	// Start the manager. This blocks until a signal is received.
 	setupLog.Info("Manager starting")
 	if err := mgr.Start(ctx); err != nil {
-		setupLog.Error(err, "Error starting manager")
 		return err
 	}
 	setupLog.Info("Manager terminated")

cmd/epp/runner/runner.go

@@ -145,7 +145,6 @@ func (r *Runner) Run(ctx context.Context) error {
 
 	// Validate flags
 	if err := validateFlags(); err != nil {
-		setupLog.Error(err, "Failed to validate flags")
 		return err
 	}
 
@@ -162,7 +161,6 @@ func (r *Runner) Run(ctx context.Context) error {
 	// --- Get Kubernetes Config ---
 	cfg, err := ctrl.GetConfig()
 	if err != nil {
-		setupLog.Error(err, "Failed to get Kubernetes rest config")
 		return err
 	}
 
@@ -206,7 +204,6 @@ func (r *Runner) Run(ctx context.Context) error {
 
 	mgr, err := runserver.NewDefaultManager(poolGKNN, cfg, metricsServerOptions, *haEnableLeaderElection)
 	if err != nil {
-		setupLog.Error(err, "Failed to create controller manager")
 		return err
 	}
 
@@ -226,7 +223,6 @@ func (r *Runner) Run(ctx context.Context) error {
 		setupLog.Info("Enabling pprof handlers")
 		err = setupPprofHandlers(mgr)
 		if err != nil {
-			setupLog.Error(err, "Failed to setup pprof handlers")
 			return err
 		}
 		runtime.SetMutexProfileFraction(1)
@@ -235,14 +231,12 @@ func (r *Runner) Run(ctx context.Context) error {
 
 	err = r.parsePluginsConfiguration(ctx)
 	if err != nil {
-		setupLog.Error(err, "Failed to parse plugins configuration")
 		return err
 	}
 
 	// --- Initialize Core EPP Components ---
 	if r.schedulerConfig == nil {
 		err := errors.New("scheduler config must be set either by config api or through code")
-		setupLog.Error(err, "failed to create scheduler")
 		return err
 	}
 
@@ -270,7 +264,6 @@ func (r *Runner) Run(ctx context.Context) error {
 		UseExperimentalDatalayerV2:       useDatalayerV2, // pluggable data layer feature flag
 	}
 	if err := serverRunner.SetupWithManager(ctx, mgr); err != nil {
-		setupLog.Error(err, "Failed to setup EPP controllers")
 		return err
 	}
 
@@ -289,7 +282,6 @@ func (r *Runner) Run(ctx context.Context) error {
 	// This blocks until a signal is received.
 	setupLog.Info("Controller manager starting")
 	if err := mgr.Start(ctx); err != nil {
-		setupLog.Error(err, "Error starting controller manager")
 		return err
 	}
 	setupLog.Info("Controller manager terminated")
@@ -362,7 +354,6 @@ func setupMetricsV1(setupLog logr.Logger) (datalayer.EndpointFactory, error) {
 		*loraInfoMetric,
 	)
 	if err != nil {
-		setupLog.Error(err, "Failed to create metric mapping from flags.")
 		return nil, err
 	}
 	verifyMetricMapping(*mapping, setupLog)
@@ -440,7 +431,6 @@ func initLogging(opts *zap.Options) {
 // registerExtProcServer adds the ExtProcServerRunner as a Runnable to the manager.
 func registerExtProcServer(mgr manager.Manager, runner *runserver.ExtProcServerRunner, logger logr.Logger) error {
 	if err := mgr.Add(runner.AsRunnable(logger)); err != nil {
-		setupLog.Error(err, "Failed to register ext-proc gRPC server runnable")
 		return err
 	}
 	setupLog.Info("ExtProc server runner added to manager.")
@@ -458,7 +448,6 @@ func registerHealthServer(mgr manager.Manager, logger logr.Logger, ds datastore.
 	})
 	if err := mgr.Add(
 		runnable.NoLeaderElection(runnable.GRPCServer("health", srv, port))); err != nil {
-		setupLog.Error(err, "Failed to register health server")
 		return err
 	}
 	return nil

internal/runnable/grpc.go

@@ -37,7 +37,6 @@ func GRPCServer(name string, srv *grpc.Server, port int) manager.Runnable {
 		// Start listening.
 		lis, err := net.Listen("tcp", fmt.Sprintf(":%d", port))
 		if err != nil {
-			log.Error(err, "gRPC server failed to listen")
 			return err
 		}
 
@@ -59,7 +58,6 @@ func GRPCServer(name string, srv *grpc.Server, port int) manager.Runnable {
 
 		// Keep serving until terminated.
 		if err := srv.Serve(lis); err != nil && err != grpc.ErrServerStopped {
-			log.Error(err, "gRPC server failed")
 			return err
 		}
 		log.Info("gRPC server terminated")

pkg/bbr/handlers/server.go

@@ -61,9 +61,6 @@ func (s *Server) Process(srv extProcPb.ExternalProcessor_ProcessServer) error {
 			return nil
 		}
 		if recvErr != nil {
-			// This error occurs very frequently, though it doesn't seem to have any impact.
-			// TODO Figure out if we can remove this noise.
-			loggerVerbose.Error(recvErr, "Cannot receive stream request")
 			return status.Errorf(codes.Unknown, "cannot receive stream request: %v", recvErr)
 		}
 
@@ -103,8 +100,6 @@ func (s *Server) Process(srv extProcPb.ExternalProcessor_ProcessServer) error {
 		if err != nil {
 			if logger.V(logutil.DEBUG).Enabled() {
 				logger.V(logutil.DEBUG).Error(err, "Failed to process request", "request", req)
-			} else {
-				logger.V(logutil.DEFAULT).Error(err, "Failed to process request")
 			}
 			return status.Errorf(status.Code(err), "failed to handle request: %v", err)
 		}
@@ -116,7 +111,6 @@ func (s *Server) Process(srv extProcPb.ExternalProcessor_ProcessServer) error {
 				loggerVerbose.Info("Response generated")
 			}
 			if err := srv.Send(resp); err != nil {
-				logger.V(logutil.DEFAULT).Error(err, "Send failed")
 				return status.Errorf(codes.Unknown, "failed to send response back to Envoy: %v", err)
 			}
 		}

pkg/bbr/server/runserver.go

@@ -54,7 +54,6 @@ func (r *ExtProcServerRunner) AsRunnable(logger logr.Logger) manager.Runnable {
 		if r.SecureServing {
 			cert, err := tlsutil.CreateSelfSignedTLSCertificate(logger)
 			if err != nil {
-				logger.Error(err, "Failed to create self signed certificate")
 				return err
 			}
 			creds := credentials.NewTLS(&tls.Config{Certificates: []tls.Certificate{cert}})

pkg/epp/controller/inferenceobjective_reconciler.go

@@ -48,7 +48,6 @@ func (c *InferenceObjectiveReconciler) Reconcile(ctx context.Context, req ctrl.R
 	notFound := false
 	if err := c.Get(ctx, req.NamespacedName, infObjective); err != nil {
 		if !errors.IsNotFound(err) {
-			logger.Error(err, "Unable to get InferenceObjective")
 			return ctrl.Result{}, err
 		}
 		notFound = true

pkg/epp/controller/inferencepool_reconciler.go

@@ -57,7 +57,6 @@ func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	default:
 		// Handle unsupported groups gracefully.
 		err := fmt.Errorf("unsupported API group: %s", c.PoolGKNN.Group)
-		logger.Error(err, "Cannot reconcile InferencePool")
 		return ctrl.Result{}, err
 	}
 
@@ -68,7 +67,6 @@ func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 			c.Datastore.Clear()
 			return ctrl.Result{}, nil
 		}
-		logger.Error(err, "Unable to get InferencePool")
 		return ctrl.Result{}, err
 	}
 
@@ -90,15 +88,13 @@ func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 		var err error
 		err = pool.ConvertTo(v1infPool)
 		if err != nil {
-			logger.Error(err, "Failed to convert XInferencePool to InferencePool")
 			return ctrl.Result{}, err
 		}
 	default:
 		return ctrl.Result{}, fmt.Errorf("unsupported API group: %s", c.PoolGKNN.Group)
 	}
 
 	if err := c.Datastore.PoolSet(ctx, c.Reader, v1infPool); err != nil {
-		logger.Error(err, "Failed to update datastore")
 		return ctrl.Result{}, err
 	}
 

pkg/epp/controller/pod_reconciler.go

@@ -55,7 +55,6 @@ func (c *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 			c.Datastore.PodDelete(req.NamespacedName)
 			return ctrl.Result{}, nil
 		}
-		logger.V(logutil.DEFAULT).Error(err, "Unable to get pod")
 		return ctrl.Result{}, err
 	}
 

pkg/epp/handlers/response.go

@@ -39,7 +39,6 @@ func (s *StreamingServer) HandleResponseBody(ctx context.Context, reqCtx *Reques
 	logger := log.FromContext(ctx)
 	responseBytes, err := json.Marshal(response)
 	if err != nil {
-		logger.V(logutil.DEFAULT).Error(err, "error marshalling responseBody")
 		return reqCtx, err
 	}
 	if response["usage"] != nil {

pkg/epp/handlers/server.go

@@ -177,9 +177,6 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
 			return nil
 		}
 		if recvErr != nil {
-			// This error occurs very frequently, though it doesn't seem to have any impact.
-			// TODO Figure out if we can remove this noise.
-			logger.V(logutil.DEFAULT).Error(err, "Cannot receive stream request")
 			return status.Errorf(codes.Unknown, "cannot receive stream request: %v", err)
 		}
 
@@ -327,15 +324,12 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
 		if err != nil {
 			if logger.V(logutil.DEBUG).Enabled() {
 				logger.V(logutil.DEBUG).Error(err, "Failed to process request", "request", req)
-			} else {
-				logger.V(logutil.DEFAULT).Error(err, "Failed to process request")
 			}
 			resp, err := buildErrResponse(err)
 			if err != nil {
 				return err
 			}
 			if err := srv.Send(resp); err != nil {
-				logger.V(logutil.DEFAULT).Error(err, "Send failed")
 				return status.Errorf(codes.Unknown, "failed to send response back to Envoy: %v", err)
 			}
 			return nil
@@ -355,7 +349,6 @@ func (r *RequestContext) updateStateAndSendIfNeeded(srv extProcPb.ExternalProces
 	if r.RequestState == RequestReceived && r.reqHeaderResp != nil {
 		loggerTrace.Info("Sending request header response", "obj", r.reqHeaderResp)
 		if err := srv.Send(r.reqHeaderResp); err != nil {
-			logger.V(logutil.DEFAULT).Error(err, "error sending response")
 			return status.Errorf(codes.Unknown, "failed to send response back to Envoy: %v", err)
 		}
 		r.RequestState = HeaderRequestResponseComplete