Skip to content

Commit ab6a02e

Browse files
committed
cleanup modelName from inferenceObjective.
1 parent 4318d95 commit ab6a02e

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

apix/v1alpha2/inferenceobjective_types.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
// +kubebuilder:object:root=true
2626
// +kubebuilder:subresource:status
2727
// +kubebuilder:storageversion
28-
// +kubebuilder:printcolumn:name="Model Name",type=string,JSONPath=`.spec.modelName`
2928
// +kubebuilder:printcolumn:name="Inference Pool",type=string,JSONPath=`.spec.poolRef.name`
3029
// +kubebuilder:printcolumn:name="Priority",type=string,JSONPath=`.spec.priority`
3130
// +kubebuilder:printcolumn:name="Age",type=date,JSONPath=`.metadata.creationTimestamp`
@@ -56,12 +55,6 @@ type InferenceObjectiveList struct {
5655
// performance and latency goals for the model. These workloads are
5756
// expected to operate within an InferencePool sharing compute capacity with other
5857
// InferenceObjectives, defined by the Inference Platform Admin.
59-
//
60-
// InferenceObjective's modelName (not the ObjectMeta name) is unique for a given InferencePool,
61-
// if the name is reused, an error will be shown on the status of a
62-
// InferenceObjective that attempted to reuse. The oldest InferenceObjective, based on
63-
// creation timestamp, will be selected to remain valid. In the event of a race
64-
// condition, one will be selected at random.
6558
type InferenceObjectiveSpec struct {
6659

6760
// Priority defines how important it is to serve the request compared to other requests in the same pool.
@@ -135,10 +128,6 @@ const (
135128
//
136129
// * "Accepted"
137130
//
138-
// Possible reasons for this condition to be False are:
139-
//
140-
// * "ModelNameInUse"
141-
//
142131
// Possible reasons for this condition to be Unknown are:
143132
//
144133
// * "Pending"
@@ -148,10 +137,6 @@ const (
148137
// ObjectiveReasonAccepted is the desired state. Model conforms to the state of the pool.
149138
ObjectiveReasonAccepted InferenceObjectiveConditionReason = "Accepted"
150139

151-
// ObjectiveReasonNameInUse is used when a given ModelName already exists within the pool.
152-
// Details about naming conflict resolution are on the ModelName field itself.
153-
ObjectiveReasonNameInUse InferenceObjectiveConditionReason = "ModelNameInUse"
154-
155140
// ObjectiveReasonPending is the initial state, and indicates that the controller has not yet reconciled the InferenceObjective.
156141
ObjectiveReasonPending InferenceObjectiveConditionReason = "Pending"
157142
)

0 commit comments

Comments
 (0)