added a generic Clone function to remove type infer in when cloning ScrapedData

Signed-off-by: Nir Rozenbaum <[email protected]>

Author: nirrozenbaum

pkg/epp/backend/metrics/fake_metrics_scraper.go

@@ -60,7 +60,7 @@ func (s *FakeMetricsScraper) Scrape(ctx context.Context, pod *backend.Pod, port
 		return nil, fmt.Errorf("no pod found: %v", pod.NamespacedName)
 	}
 	log.FromContext(ctx).V(logutil.VERBOSE).Info("Fetching metrics for pod", "existing", s.existingMetrics, "new", res)
-	return res.Clone(), nil
+	return podinfo.Clone(res), nil
 }
 
 func (s *FakeMetricsScraper) ProcessResult(ctx context.Context, podinfo podinfo.ScrapedData) {} // noop

pkg/epp/backend/metrics/metrics_scraper.go

@@ -105,7 +105,7 @@ func (s *MetricsScraper) ProcessResult(ctx context.Context, data podinfo.Scraped
 // promToPodMetrics updates internal pod metrics with scraped Prometheus metrics.
 func (s *MetricsScraper) promToPodMetrics(metricFamilies map[string]*dto.MetricFamily) (podinfo.ScrapedData, error) {
 	var errs error
-	updated := s.existingMetrics.Clone().(*Metrics)
+	updated := podinfo.Clone(s.existingMetrics)
 
 	if s.MetricMapping.TotalQueuedRequests != nil {
 		queued, err := s.getMetric(metricFamilies, *s.MetricMapping.TotalQueuedRequests)

pkg/epp/backend/pod-info/types.go

@@ -65,3 +65,9 @@ type Datastore interface {
 	// PodGetAll() []PodMetrics
 	// PodList(func(PodMetrics) bool) []PodMetrics
 }
+
+// Clone is a generic function that clones any struct that implements ScrapedData interface.
+func Clone[T ScrapedData](base T) T {
+	copy := base.Clone()
+	return copy.(T)
+}