clarify use of ready channel in testing

Signed-off-by: Etai Lev Ran <[email protected]>

Author: elevran

pkg/epp/datalayer/collector.go

@@ -121,7 +121,12 @@ func (c *Collector) Start(ctx context.Context, ticker Ticker, ep Endpoint, sourc
 		return errors.New("collector start called multiple times")
 	}
 
-	select { // wait for goroutine to signal readiness
+	// Wait for goroutine to signal readiness.
+	// The use of ready channel is mostly to make the function testable, by ensuring
+	// synchronous order of events. Ignoring test requirements, one could let the
+	// go routine start at some arbitrary point in the future, possibly after this
+	// function has returned.
+	select {
 	case <-ready:
 		return nil
 	case <-ctx.Done():

pkg/epp/datalayer/collector_test.go

@@ -108,9 +108,6 @@ func TestCollectorCollectsOnTicks(t *testing.T) {
 		return atomic.LoadInt64(&source.callCount) == 2
 	}, 1*time.Second, 2*time.Millisecond, "expected 2 collections")
 
-	got := atomic.LoadInt64(&source.callCount)
-	want := int64(2)
-	assert.Equal(t, want, got, "call count mismatch")
 	require.NoError(t, c.Stop())
 }