Skip to content

🏃 (:running:, other) Try to stabilize the flaky process_test #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

🏃 (:running:, other) Try to stabilize the flaky process_test #777

merged 1 commit into from
Feb 4, 2020

Conversation

alenkacz
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2020
@alenkacz
Copy link
Contributor Author

/retest

@gerred gerred mentioned this pull request Jan 23, 2020
Closed
vincepri
vincepri approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @gerred

I would also try to see if we need to assign more resources to our prow jobs, like CPU and memory. We've done this for Cluster API and it has worked nicely. I can take a look later.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2020
kensipe
kensipe approved these changes Jan 23, 2020
View reviewed changes
Copy link

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gerred
Copy link
Contributor

gerred commented Jan 28, 2020

/approve

@alenkacz
Copy link
Contributor Author

alenkacz commented Feb 1, 2020

@gerred can you please re-approve?

@gerred
Copy link
Contributor

gerred commented Feb 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, gerred

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 65d0423 into kubernetes-sigs:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@vincepri vincepri vincepri approved these changes

@gerred gerred Awaiting requested review from gerred

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@kensipe kensipe

@gerred gerred

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alenkacz @gerred @k8s-ci-robot @kensipe @vincepri