Why is a Logger not injected by the Controller Manager?

[akutz]

Hi there,

Along with the other injector-style interfaces, there is InjectLogger,

controller-runtime/pkg/runtime/inject/inject.go

Lines 149 to 153 in 57ed2a3

	// Logger is used to inject Loggers into components that need them
	// and don't otherwise have opinions.
	type Logger interface {
	InjectLogger(l logr.Logger) error
	}

However, the only place this seems to be used is with respect to webhooks.

Why is InjectLogger not part of the SetFields function in the Controller Manager so loggers are added to components added to the manager at

controller-runtime/pkg/manager/internal.go

Lines 244 to 270 in ea795f6

	func (cm *controllerManager) SetFields(i interface{}) error {
	if _, err := inject.ConfigInto(cm.config, i); err != nil {
	return err
	}
	if _, err := inject.ClientInto(cm.client, i); err != nil {
	return err
	}
	if _, err := inject.APIReaderInto(cm.apiReader, i); err != nil {
	return err
	}
	if _, err := inject.SchemeInto(cm.scheme, i); err != nil {
	return err
	}
	if _, err := inject.CacheInto(cm.cache, i); err != nil {
	return err
	}
	if _, err := inject.InjectorInto(cm.SetFields, i); err != nil {
	return err
	}
	if _, err := inject.StopChannelInto(cm.internalStop, i); err != nil {
	return err
	}
	if _, err := inject.MapperInto(cm.mapper, i); err != nil {
	return err
	}
	return nil
	}

[alvaroaleman]

Looks like an oversight

[vincepri]

/milestone v0.6.x
/kind bug

Can/Should also be backported.

[vincepri]

/help

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jiachengxu]

Would like to work on this :)
/assign