chore: address the comments

Signed-off-by: STRRL <[email protected]>

Author: STRRL

pkg/webhook/admission/admissiontest/util.go

@@ -47,8 +47,8 @@ func (v *FakeValidator) ValidateDelete() (warnings []string, err error) {
 	return v.WarningsToReturn, v.ErrorToReturn
 }
 
-func (v *FakeValidator) SetGroupVersionKind(kind schema.GroupVersionKind) {
-	v.GVKToReturn = kind
+func (v *FakeValidator) SetGroupVersionKind(gvk schema.GroupVersionKind) {
+	v.GVKToReturn = gvk
 }
 
 func (v *FakeValidator) GroupVersionKind() schema.GroupVersionKind {
@@ -60,7 +60,8 @@ func (v *FakeValidator) GetObjectKind() schema.ObjectKind {
 }
 
 func (v *FakeValidator) DeepCopyObject() runtime.Object {
-	return &FakeValidator{ErrorToReturn: v.ErrorToReturn,
+	return &FakeValidator{
+		ErrorToReturn:    v.ErrorToReturn,
 		GVKToReturn:      v.GVKToReturn,
 		WarningsToReturn: v.WarningsToReturn,
 	}

pkg/webhook/admission/validator.go

@@ -80,8 +80,7 @@ func (h *validatingHandler) Handle(ctx context.Context, req Request) Response {
 		// No validation for connect requests.
 		// TODO(vincepri): Should we validate CONNECT requests? In what cases?
 	case v1.Create:
-		err = h.decoder.Decode(req, obj)
-		if err != nil {
+		if err = h.decoder.Decode(req, obj); err != nil {
 			return Errored(http.StatusBadRequest, err)
 		}
 
@@ -109,7 +108,7 @@ func (h *validatingHandler) Handle(ctx context.Context, req Request) Response {
 
 		warnings, err = obj.ValidateDelete()
 	default:
-		return Errored(http.StatusBadRequest, fmt.Errorf("unknown operation request %q", req.Operation))
+		return Errored(http.StatusBadRequest, fmt.Errorf("unknown operation %q", req.Operation))
 	}
 
 	if err != nil {

pkg/webhook/admission/validator_custom.go

@@ -109,7 +109,7 @@ func (h *validatorForType) Handle(ctx context.Context, req Request) Response {
 
 		warnings, err = h.validator.ValidateDelete(ctx, obj)
 	default:
-		return Errored(http.StatusBadRequest, fmt.Errorf("unknown operation request %q", req.Operation))
+		return Errored(http.StatusBadRequest, fmt.Errorf("unknown operation %q", req.Operation))
 	}
 
 	// Check the error message first.