Merge pull request #2290 from vincepri/errors-more-info

k8s-ci-robot · web-flow · commit 0ef07535542b · 2023-04-27T08:38:17.000-07:00
🌱 Kind source should expose type information on timeout
diff --git a/pkg/internal/source/kind.go b/pkg/internal/source/kind.go
@@ -112,6 +112,6 @@ func (ks *Kind) WaitForSync(ctx context.Context) error {
 		if errors.Is(ctx.Err(), context.Canceled) {
 			return nil
 		}
-		return errors.New("timed out waiting for cache to be synced")
+		return fmt.Errorf("timed out waiting for cache to be synced for Kind %T", ks.Type)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,6 @@ func (ks *Kind) WaitForSync(ctx context.Context) error {`
`112`	`112`	`if errors.Is(ctx.Err(), context.Canceled) {`
`113`	`113`	`return nil`
`114`	`114`	`}`
`115`		`- return errors.New("timed out waiting for cache to be synced")`
	`115`	`+ return fmt.Errorf("timed out waiting for cache to be synced for Kind %T", ks.Type)`
`116`	`116`	`}`
`117`	`117`	`}`