Skip to content

Commit fcc777c

Browse files
committed
Reverted redundant changes to MachineSet and MachineDeploymentSpec conversion code
1 parent 13c408e commit fcc777c

File tree

2 files changed

+21
-41
lines changed

2 files changed

+21
-41
lines changed

api/v1alpha2/conversion.go

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ func Convert_v1alpha2_MachineSpec_To_v1alpha3_MachineSpec(in *MachineSpec, out *
275275

276276
if in.Bootstrap.ConfigRef != nil {
277277
gvk := in.Bootstrap.ConfigRef.GetObjectKind().GroupVersionKind()
278-
if gvk.Group == bootstrapv1a3.GroupVersion.Group && gvk.Kind == kubeadmConfigKind {
278+
if gvk.Group == bootstrapv1a3.GroupVersion.Group && (gvk.Kind == kubeadmConfigKind || gvk.Kind == kubeadmConfigTemplateKind) {
279279
out.Bootstrap.ConfigRef.APIVersion = bootstrapv1a3.GroupVersion.String()
280280
}
281281
}
@@ -285,36 +285,6 @@ func Convert_v1alpha2_MachineSpec_To_v1alpha3_MachineSpec(in *MachineSpec, out *
285285
return nil
286286
}
287287

288-
func Convert_v1alpha2_MachineSetSpec_To_v1alpha3_MachineSetSpec(in *MachineSetSpec, out *v1alpha3.MachineSetSpec, s apiconversion.Scope) error {
289-
if err := autoConvert_v1alpha2_MachineSetSpec_To_v1alpha3_MachineSetSpec(in, out, s); err != nil {
290-
return err
291-
}
292-
293-
if in.Template.Spec.Bootstrap.ConfigRef != nil {
294-
gvk := in.Template.Spec.Bootstrap.ConfigRef.GetObjectKind().GroupVersionKind()
295-
if gvk.Group == bootstrapv1a3.GroupVersion.Group && gvk.Kind == kubeadmConfigTemplateKind {
296-
out.Template.Spec.Bootstrap.ConfigRef.APIVersion = bootstrapv1a3.GroupVersion.String()
297-
}
298-
}
299-
300-
return nil
301-
}
302-
303-
func Convert_v1alpha2_MachineDeploymentSpec_To_v1alpha3_MachineDeploymentSpec(in *MachineDeploymentSpec, out *v1alpha3.MachineDeploymentSpec, s apiconversion.Scope) error {
304-
if err := autoConvert_v1alpha2_MachineDeploymentSpec_To_v1alpha3_MachineDeploymentSpec(in, out, s); err != nil {
305-
return err
306-
}
307-
308-
if in.Template.Spec.Bootstrap.ConfigRef != nil {
309-
gvk := in.Template.Spec.Bootstrap.ConfigRef.GetObjectKind().GroupVersionKind()
310-
if gvk.Group == bootstrapv1a3.GroupVersion.Group && gvk.Kind == kubeadmConfigTemplateKind {
311-
out.Template.Spec.Bootstrap.ConfigRef.APIVersion = bootstrapv1a3.GroupVersion.String()
312-
}
313-
}
314-
315-
return nil
316-
}
317-
318288
func Convert_v1alpha2_ClusterSpec_To_v1alpha3_ClusterSpec(in *ClusterSpec, out *v1alpha3.ClusterSpec, s apiconversion.Scope) error {
319289
if err := autoConvert_v1alpha2_ClusterSpec_To_v1alpha3_ClusterSpec(in, out, s); err != nil {
320290
return err

api/v1alpha2/zz_generated.conversion.go

Lines changed: 20 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)