Skip to content

Commit b2c6421

Browse files
fiunchinhodetiber
andauthored
Apply suggestions from code review
Co-authored-by: Jason DeTiberus <[email protected]>
1 parent e998771 commit b2c6421

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

docs/proposals/20190919-machinepool-api.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,7 @@ type MachinePoolSpec struct
168168
- Description: Name of the Cluster this machine pool belongs to.
169169
- **FailureDomains [optional]**
170170
- Type: `FailureDomains`
171-
- Description: FailureDomainSpec is the Schema for Cluster API failure domains.
172-
It allows controllers to understand how many failure domains a cluster can optionally span across.
171+
- Description: FailureDomains are the failure domains the MachinePool instances should be be created in.
173172
- **Replicas [optional]**
174173
- Type: `*int32`
175174
- Description: Number of desired machine instances. Defaults to 1.
@@ -419,4 +418,3 @@ inconsistent experience across providers.
419418
10/23/2019: First round of feedback from community
420419
10/23/2019: Present proposal at a community meeting
421420
10/31/2019: Open proposal PR
422-

exp/api/v1alpha3/machinepool_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ type MachinePoolSpec struct {
6060
// +optional
6161
ProviderIDList []string `json:"providerIDList,omitempty"`
6262

63-
// FailureDomains is the list of failure domains this MachinePool should be attached to.
63+
// FailureDomains are the failure domains the MachinePool instances should be be created in.
6464
FailureDomains clusterv1.FailureDomains `json:"failureDomains,omitempty"`
6565
}
6666

0 commit comments

Comments
 (0)