bugfix to handle verify from cloud.yaml (ca still doesn't work)

Author: sbueringer

pkg/cloud/services/provider/provider.go

@@ -57,6 +57,10 @@ func NewClientFromCluster(ctrlClient client.Client, openStackCluster *infrav1.Op
 	return newClient(cloud, caCert)
 }
 
+// TODO(sbueringer) find out if this function does what we want
+// e.g. it had a bug where it didn't use the verify option of the
+// cloud parameter. Does it read the ca property from the paramenter?
+// how can a CA be set via secret? (an additional key?)
 func newClient(cloud clientconfig.Cloud, caCert []byte) (*gophercloud.ProviderClient, *clientconfig.ClientOpts, error) {
 	clientOpts := new(clientconfig.ClientOpts)
 	if cloud.AuthInfo != nil {
@@ -86,14 +90,16 @@ func newClient(cloud clientconfig.Cloud, caCert []byte) (*gophercloud.ProviderCl
 			config.RootCAs = caCertPool
 		}
 		config.InsecureSkipVerify = !*cloudFromYaml.Verify
+	} else {
+		config.InsecureSkipVerify = !*cloud.Verify
 	}
 
 	transport := &http.Transport{Proxy: http.ProxyFromEnvironment, TLSClientConfig: config}
 	provider.HTTPClient.Transport = transport
 
 	err = openstack.Authenticate(provider, *opts)
 	if err != nil {
-		return nil, nil, fmt.Errorf("providerClient authentication err: %v", err)
+		return nil, nil, fmt.Errorf("providerClient authentication err: %v, %+v", err, cloudFromYaml)
 	}
 	return provider, clientOpts, nil
 }