Add support for PortForward. #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandburns
force-pushed
the
port-forward
branch
from
8438bde to
52c57cd
Compare
lwander
reviewed
Oct 9, 2017
| streamRequest(request, client, listener); | ||
| } | ||
|
|
||
| /** If we ever upgrade to okhttp 3... |
There was a problem hiding this comment.
I think this might get interpreted as a javadoc with that extra *
| public OutputStream getOutboundStream(int port) { | ||
| int portIndex = findPortIndex(port); | ||
| if (portIndex == -1) { | ||
| throw new IllegalArgumentException("No such port!"); |
There was a problem hiding this comment.
Would it be neater to have findPortIndex(..) throw this exception instead?
There was a problem hiding this comment.
switched to return null instead of throw.
| WebSocketStreamHandler handler = new WebSocketStreamHandler(); | ||
| PortForwardResult result = new PortForwardResult(handler, ports); | ||
| List<Pair> queryParams = new ArrayList<>(); | ||
| queryParams.add(new Pair("ports", "80")); |
There was a problem hiding this comment.
Is it always '80' or just once for the example you gave above?
There was a problem hiding this comment.
ugh! good catch, fixed.
| * I/O for first port (80) is on Channel 0 | ||
| * Err for first port (80) is on Channel 1 | ||
| * I/O for second port (8080) is on Channel 2 | ||
| * Err for second port (8080) is on Channel 2 |
There was a problem hiding this comment.
Good catch, fixed.
| * | ||
| * @param namespace The namespace of the Pod | ||
| * @param name The name of the Pod | ||
| * @param ports The ports to forward |
There was a problem hiding this comment.
Please add @return, I don't think our linter is catching it but the release will fail w/o it.
| * PortForward to a container | ||
| * | ||
| * @param pod The pod where the port forward is run. | ||
| * @param ports The ports to forward |
|
|
||
| /** | ||
| * Get the API client for these PortForward operations. | ||
| * @returns The API client that will be used. |
brendandburns
force-pushed
the
port-forward
branch
from
52c57cd to
d59e5bb
Compare
|
@lwander comments addressed, please take another look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Uses WebSocket for Port Forward as added by kubernetes/kubernetes#33684
@mbohlool @lwander