Skip to content

bugfix KubernetesApiResponse cannot be cast to class KubernetesObject #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2021
Merged

bugfix KubernetesApiResponse cannot be cast to class KubernetesObject #1631

merged 3 commits into from
Apr 12, 2021

Conversation

lin1005q
Copy link
Contributor

@lin1005q lin1005q commented Apr 3, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2021
@lin1005q
Copy link
Contributor Author

lin1005q commented Apr 3, 2021

/assign @yue9944882 When is the next release?

@lin1005q lin1005q requested a review from brendandburns April 7, 2021 04:42
yue9944882
yue9944882 reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@lin1005q are you expecting cherry-picking this to any history release?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lin1005q, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@yue9944882 yue9944882 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0f78b73 into kubernetes-client:master Apr 12, 2021
@lin1005q
Copy link
Contributor Author

/lgtm
/approve

@lin1005q are you expecting cherry-picking this to any history release?

I haven't done it before, but I want to give it a try.
I saw the KubectlPatch class began to appear on the release-10 branch. Please confirm which branch I need to cherry-picking on?

This was referenced Jun 9, 2021
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 11, 2021
@k8s-ci-robot
Merge pull request #1743 from lin1005q/release-11
0e1efd0 
Cherry-pick of #1631 into Release-11
k8s-ci-robot added a commit that referenced this pull request Jun 11, 2021
@k8s-ci-robot
Merge pull request #1742 from lin1005q/release-12
ef00041 
Cherry-pick of #1631 into Release-12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 yue9944882 left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@yue9944882 yue9944882

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lin1005q @k8s-ci-robot @brendandburns @yue9944882