Skip to content

Enforcing read-timeout for informer-factory processor via property "kubernetes.informer.clientReadTimeout" (default 5min) #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Mar 12, 2021

apiClient.setHttpClient(
apiClient.getHttpClient().newBuilder().readTimeout(Duration.ZERO).build());

these lines were dropped during refactoring informer-processor and this pull adds it back. tho this can workaround by explicitly setting the read-timeout to zero upon instanciating the ApiClient bean.

/cc @brendandburns @dsyer

@k8s-ci-robot
Copy link
Contributor

@yue9944882: GitHub didn't allow me to request PR reviews from the following users: dsyer.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

apiClient.setHttpClient(
apiClient.getHttpClient().newBuilder().readTimeout(Duration.ZERO).build());

these lines were dropped during refactoring informer-processor and this pull adds it back.

/cc @brendandburns @dsyer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2021
@brendandburns
Copy link
Contributor

I'm still not sure we want to force the timeout to infinite. There are lots of examples where the network is a little flaky and timing out a some interval (eg. 3 minutes) makes sense.

@brendandburns
Copy link
Contributor

e.g. #1578

@yue9944882 yue9944882 force-pushed the feat/informer-processor-zero-readtimeout branch from 62bd2ee to 89e4ecf Compare March 15, 2021 06:15
@yue9944882
Copy link
Member Author

@brendandburns i updated readtimeout to 5min to align w/ the reflector

@yue9944882 yue9944882 force-pushed the feat/informer-processor-zero-readtimeout branch from 89e4ecf to 78c3306 Compare March 15, 2021 06:22
@yue9944882 yue9944882 changed the title Enforcing read-timeout for informer-factory processor to zero Enforcing read-timeout for informer-factory processor to 5min Mar 15, 2021
@yue9944882 yue9944882 force-pushed the feat/informer-processor-zero-readtimeout branch from 78c3306 to b9e80fb Compare March 17, 2021 11:17
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2021
@yue9944882 yue9944882 force-pushed the feat/informer-processor-zero-readtimeout branch from b9e80fb to 63abb43 Compare March 17, 2021 11:20
@yue9944882 yue9944882 changed the title Enforcing read-timeout for informer-factory processor to 5min Enforcing read-timeout for informer-factory processor via property "kubernetes.informer.clientReadTimeout" (default 5min) Mar 17, 2021
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants