-
Notifications
You must be signed in to change notification settings - Fork 2k
Enforcing read-timeout for informer-factory processor via property "kubernetes.informer.clientReadTimeout" (default 5min) #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yue9944882: GitHub didn't allow me to request PR reviews from the following users: dsyer. Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm still not sure we want to force the timeout to infinite. There are lots of examples where the network is a little flaky and timing out a some interval (eg. 3 minutes) makes sense. |
e.g. #1578 |
62bd2ee
to
89e4ecf
Compare
@brendandburns i updated readtimeout to 5min to align w/ the reflector |
89e4ecf
to
78c3306
Compare
78c3306
to
b9e80fb
Compare
…ubernetes.informer.clientReadTimeout"
b9e80fb
to
63abb43
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
java/spring/src/main/java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java
Lines 95 to 96 in d9271d4
these lines were dropped during refactoring informer-processor and this pull adds it back. tho this can workaround by explicitly setting the read-timeout to zero upon instanciating the ApiClient bean.
/cc @brendandburns @dsyer