Skip to content

Commit cfa6452

Browse files
author
Kartik Shenoy
committed
Dropping support to avoid mapping conflicts with NERDTree till I find a good way to identify when we leave NERDTree
1 parent 485c1f8 commit cfa6452

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

autoload/signature/utils.vim

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,16 @@ function! signature#utils#Maps(mode)
3636
" We create separate mappings for PlaceNextMark, mark#Purge('all') and PurgeMarkers instead of combining it with
3737
" Leader/Input as if the user chooses to use some weird key like <BS> or <CR> for any of these 3, we need to be able
3838
" to identify it. Eg. the nr2char(getchar()) will fail if the user presses a <BS>
39-
let s:SignatureMapLeader = get(g:SignatureMap, 'Leader', 'm')
40-
if (s:SignatureMapLeader == "")
39+
let l:SignatureMapLeader = get(g:SignatureMap, 'Leader', 'm')
40+
if (l:SignatureMapLeader == "")
4141
echoe "Signature: g:SignatureMap.Leader shouldn't be left blank"
4242
endif
43-
call s:Map(a:mode, 'Leader' , s:SignatureMapLeader , 'utils#Input()' )
44-
call s:Map(a:mode, 'PlaceNextMark' , s:SignatureMapLeader . "," , 'mark#Toggle("next")' )
45-
call s:Map(a:mode, 'ToggleMarkAtLine' , s:SignatureMapLeader . "." , 'mark#ToggleAtLine()' )
46-
call s:Map(a:mode, 'PurgeMarksAtLine' , s:SignatureMapLeader . "-" , 'mark#Purge("line")' )
47-
call s:Map(a:mode, 'PurgeMarks' , s:SignatureMapLeader . "<Space>", 'mark#Purge("all")' )
48-
call s:Map(a:mode, 'PurgeMarkers' , s:SignatureMapLeader . "<BS>" , 'marker#Purge()' )
43+
call s:Map(a:mode, 'Leader' , l:SignatureMapLeader , 'utils#Input()' )
44+
call s:Map(a:mode, 'PlaceNextMark' , l:SignatureMapLeader . "," , 'mark#Toggle("next")' )
45+
call s:Map(a:mode, 'ToggleMarkAtLine' , l:SignatureMapLeader . "." , 'mark#ToggleAtLine()' )
46+
call s:Map(a:mode, 'PurgeMarksAtLine' , l:SignatureMapLeader . "-" , 'mark#Purge("line")' )
47+
call s:Map(a:mode, 'PurgeMarks' , l:SignatureMapLeader . "<Space>", 'mark#Purge("all")' )
48+
call s:Map(a:mode, 'PurgeMarkers' , l:SignatureMapLeader . "<BS>" , 'marker#Purge()' )
4949
call s:Map(a:mode, 'DeleteMark' , "dm" , 'utils#Remove(v:count)' )
5050
call s:Map(a:mode, 'GotoNextLineAlpha', "']" , 'mark#Goto("next", "line", "alpha")' )
5151
call s:Map(a:mode, 'GotoPrevLineAlpha', "'[" , 'mark#Goto("prev", "line", "alpha")' )

plugin/signature.vim

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -60,19 +60,6 @@ if has('autocmd')
6060
autocmd CursorHold * if g:SignaturePeriodicRefresh
6161
\| call signature#sign#Refresh()
6262
\|endif
63-
64-
" To avoid conflicts with NERDTree. Figure out a cleaner way.
65-
" Food for thought: If NERDTree creates buffer specific maps, shouldn't it override Signature's maps?
66-
autocmd BufEnter,FileType * if ( (&filetype ==? 'nerdtree')
67-
\ || (&filetype ==? 'netrw')
68-
\ )
69-
\| call signature#utils#Maps('remove')
70-
\| endif
71-
autocmd BufLeave * if ( (&filetype ==? 'nerdtree')
72-
\ || (&filetype ==? 'netrw')
73-
\ )
74-
\| call signature#utils#Maps('create')
75-
\| endif
7663
augroup END
7764
endif
7865

0 commit comments

Comments
 (0)