Skip to content

Commit bbb45fb

Browse files
authored
feature: adding full client-side tests for regular window creation (#14)
feature: adding full client-side tests for regular window creation
1 parent 009c2e0 commit bbb45fb

File tree

3 files changed

+207
-180
lines changed

3 files changed

+207
-180
lines changed

packages/flutter/lib/src/widgets/window.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ class _RegularWindowState extends State<RegularWindow> {
159159

160160
@override
161161
Future<void> dispose() async {
162+
super.dispose();
163+
162164
if (_listener != null) {
163165
assert(_app != null);
164166
_app!._unregisterListener(_listener!);
@@ -168,13 +170,11 @@ class _RegularWindowState extends State<RegularWindow> {
168170
// we need to destroy the window on our way out.
169171
if (!_hasBeenDestroyed && _viewId != null) {
170172
// In the event of an argument error, we do nothing. We assume that
171-
// the window has been successfully destroyed somehow else.
173+
// the window has been successfully destroyed somehow else.
172174
try {
173175
await destroyWindow(_viewId!);
174176
} on ArgumentError {}
175177
}
176-
177-
super.dispose();
178178
}
179179

180180
@override

packages/flutter/test/widgets/window.dart

Lines changed: 0 additions & 177 deletions
This file was deleted.

0 commit comments

Comments
 (0)