Add SetState and remove unused GetState

Author: hbatagelo

engine/src/flutter/shell/platform/windows/flutter_host_window.cc

@@ -446,10 +446,6 @@ FlutterHostWindow* FlutterHostWindow::GetThisFromHandle(HWND hwnd) {
       GetWindowLongPtr(hwnd, GWLP_USERDATA));
 }
 
-WindowState FlutterHostWindow::GetState() const {
-  return state_;
-}
-
 HWND FlutterHostWindow::GetWindowHandle() const {
   return window_handle_;
 }
@@ -593,6 +589,25 @@ void FlutterHostWindow::SetChildContent(HWND content) {
              client_rect.bottom - client_rect.top, true);
 }
 
+void FlutterHostWindow::SetState(WindowState state) {
+  WINDOWPLACEMENT window_placement = {.length = sizeof(WINDOWPLACEMENT)};
+  GetWindowPlacement(window_handle_, &window_placement);
+  window_placement.showCmd = [&]() {
+    switch (state) {
+      case WindowState::kRestored:
+        return SW_RESTORE;
+      case WindowState::kMaximized:
+        return SW_MAXIMIZE;
+      case WindowState::kMinimized:
+        return SW_MINIMIZE;
+      default:
+        FML_UNREACHABLE();
+    };
+  }();
+  SetWindowPlacement(window_handle_, &window_placement);
+  state_ = state;
+}
+
 void FlutterHostWindow::SetTitle(std::string_view title) const {
   std::wstring title_wide = StringToWstring(title);
   SetWindowText(window_handle_, title_wide.c_str());

engine/src/flutter/shell/platform/windows/flutter_host_window.h

@@ -33,9 +33,6 @@ class FlutterHostWindow {
   // Returns the instance pointer for |hwnd| or nulllptr if invalid.
   static FlutterHostWindow* GetThisFromHandle(HWND hwnd);
 
-  // Returns the current window state.
-  WindowState GetState() const;
-
   // Returns the backing window handle, or nullptr if the native window is not
   // created or has already been destroyed.
   HWND GetWindowHandle() const;
@@ -63,6 +60,9 @@ class FlutterHostWindow {
   // Inserts |content| into the window tree.
   void SetChildContent(HWND content);
 
+  // Sets the window state.
+  void SetState(WindowState state);
+
   // Sets the window title.
   void SetTitle(std::string_view title) const;
 

engine/src/flutter/shell/platform/windows/flutter_host_window_controller.cc

@@ -69,8 +69,6 @@ bool FlutterHostWindowController::ModifyHostWindow(
     return false;
   }
 
-  HWND const window_handle = window->GetWindowHandle();
-
   std::optional<Size> changed_size;
   Size const size_before = GetViewSize(view_id);
 
@@ -81,22 +79,7 @@ bool FlutterHostWindowController::ModifyHostWindow(
     window->SetTitle(*settings.title);
   }
   if (settings.state.has_value()) {
-    WINDOWPLACEMENT window_placement = {.length = sizeof(WINDOWPLACEMENT)};
-    if (GetWindowPlacement(window_handle, &window_placement)) {
-      window_placement.showCmd = [&]() {
-        switch (*settings.state) {
-          case WindowState::kRestored:
-            return SW_RESTORE;
-          case WindowState::kMaximized:
-            return SW_MAXIMIZE;
-          case WindowState::kMinimized:
-            return SW_MINIMIZE;
-          default:
-            FML_UNREACHABLE();
-        };
-      }();
-      SetWindowPlacement(window_handle, &window_placement);
-    }
+    window->SetState(*settings.state);
   }
 
   Size const size_after = GetViewSize(view_id);