Reverts "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter#166698)" (flutter#166866)

<!-- start_original_pr_link -->
Reverts: flutter#166698
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: tests are timing out in presubmit
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bkonyi
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jyameo}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This will eventually be used as the main communication channel between
the widget preview scaffold, the Flutter tool, and other developer
tooling (e.g., IDEs).

Fixes flutter#166417
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>

Author: auto-submit[bot]

packages/flutter_tools/lib/executable.dart

@@ -258,8 +258,6 @@ List<FlutterCommand> generateCommands({required bool verboseHelp, required bool
         platform: globals.platform,
         shutdownHooks: globals.shutdownHooks,
         os: globals.os,
-        processManager: globals.processManager,
-        artifacts: globals.artifacts!,
       ),
       UpgradeCommand(verboseHelp: verboseHelp),
       SymbolizeCommand(stdio: globals.stdio, fileSystem: globals.fs),

packages/flutter_tools/lib/src/commands/widget_preview.dart

@@ -5,9 +5,7 @@
 import 'package:args/args.dart';
 import 'package:meta/meta.dart';
 import 'package:package_config/package_config.dart';
-import 'package:process/process.dart';
 
-import '../artifacts.dart';
 import '../base/common.dart';
 import '../base/deferred_component.dart';
 import '../base/file_system.dart';
@@ -26,8 +24,6 @@ import '../linux/build_linux.dart';
 import '../macos/build_macos.dart';
 import '../project.dart';
 import '../runner/flutter_command.dart';
-import '../runner/flutter_command_runner.dart';
-import '../widget_preview/dtd_services.dart';
 import '../widget_preview/preview_code_generator.dart';
 import '../widget_preview/preview_detector.dart';
 import '../widget_preview/preview_manifest.dart';
@@ -45,8 +41,6 @@ class WidgetPreviewCommand extends FlutterCommand {
     required Platform platform,
     required ShutdownHooks shutdownHooks,
     required OperatingSystemUtils os,
-    required ProcessManager processManager,
-    required Artifacts artifacts,
   }) {
     addSubcommand(
       WidgetPreviewStartCommand(
@@ -58,8 +52,6 @@ class WidgetPreviewCommand extends FlutterCommand {
         platform: platform,
         shutdownHooks: shutdownHooks,
         os: os,
-        processManager: processManager,
-        artifacts: artifacts,
       ),
     );
     addSubcommand(
@@ -126,8 +118,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
     required this.platform,
     required this.shutdownHooks,
     required this.os,
-    required this.processManager,
-    required this.artifacts,
   }) {
     addPubOptions();
     argParser
@@ -162,9 +152,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
   static const String kHeadlessWeb = 'headless-web';
   static const String kWidgetPreviewScaffoldOutputDir = 'scaffold-output-dir';
 
-  /// Environment variable used to pass the DTD URI to the widget preview scaffold.
-  static const String kWidgetPreviewDtdUriEnvVar = 'WIDGET_PREVIEW_DTD_URI';
-
   @override
   Future<Set<DevelopmentArtifact>> get requiredArtifacts async => const <DevelopmentArtifact>{
     // Ensure the Flutter Web SDK is installed.
@@ -198,10 +185,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
 
   final OperatingSystemUtils os;
 
-  final ProcessManager processManager;
-
-  final Artifacts artifacts;
-
   late final FlutterProject rootProject = getRootProject();
 
   late final PreviewDetector _previewDetector = PreviewDetector(
@@ -220,12 +203,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
     cache: cache,
   );
 
-  late final WidgetPreviewDtdServices _dtdService = WidgetPreviewDtdServices(
-    logger: logger,
-    shutdownHooks: shutdownHooks,
-    dtdLauncher: DtdLauncher(logger: logger, artifacts: artifacts, processManager: processManager),
-  );
-
   /// The currently running instance of the widget preview scaffold.
   AppInstance? _widgetPreviewApp;
 
@@ -307,7 +284,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
       shutdownHooks.addShutdownHook(() async {
         await _widgetPreviewApp?.stop();
       });
-      await configureDtd();
       _widgetPreviewApp = await runPreviewEnvironment(
         widgetPreviewScaffoldProject: rootProject.widgetPreviewScaffoldProject,
       );
@@ -333,31 +309,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
     _populatePreviewPubspec(rootProject: rootProject);
   }
 
-  /// Configures the Dart Tooling Daemon connection.
-  ///
-  /// If --dtd-uri is provided, the existing DTD instance will be used. If the tool fails to
-  /// connect to this URI, it will start its own DTD instance.
-  ///
-  /// If --dtd-uri is not provided, a DTD instance managed by the tool will be started.
-  Future<void> configureDtd() async {
-    final String? existingDtdUriStr = stringArg(FlutterGlobalOptions.kDtdUrl, global: true);
-    Uri? existingDtdUri;
-    try {
-      if (existingDtdUriStr != null) {
-        existingDtdUri = Uri.parse(existingDtdUriStr);
-      }
-    } on FormatException {
-      logger.printWarning('Failed to parse value of --dtd-uri: $existingDtdUriStr.');
-    }
-    if (existingDtdUri == null) {
-      logger.printTrace('Launching a fresh DTD instance...');
-      await _dtdService.launchAndConnect();
-    } else {
-      logger.printTrace('Connecting to existing DTD instance at: $existingDtdUri...');
-      await _dtdService.connect(dtdWsUri: existingDtdUri);
-    }
-  }
-
   /// Builds the application binary for the widget preview scaffold the first
   /// time the widget preview command is run.
   ///
@@ -506,12 +457,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
             BuildMode.debug,
             null,
             treeShakeIcons: false,
-            // Provide the DTD connection information directly to the preview scaffold.
-            // This could, in theory, be provided via a follow up call to a service extension
-            // registered by the preview scaffold, but there's some uncertainty around how service
-            // extensions will work with Flutter web embedded in VSCode without a Chrome debugger
-            // connection.
-            dartDefines: <String>['$kWidgetPreviewDtdUriEnvVar=${_dtdService.dtdUri}'],
             extraFrontEndOptions:
                 isWeb ? <String>['--dartdevc-canary', '--dartdevc-module-format=ddc'] : null,
             packageConfigPath: widgetPreviewScaffoldProject.packageConfig.path,
@@ -654,7 +599,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
         if (offline) '--offline',
         '--directory',
         widgetPreviewScaffoldProject.directory.path,
-        'dtd',
         'flutter_lints',
         'stack_trace',
       ],

packages/flutter_tools/lib/src/runner/flutter_command_runner.dart

@@ -36,7 +36,6 @@ abstract final class FlutterGlobalOptions {
   static const String kMachineFlag = 'machine';
   static const String kPackagesOption = 'packages';
   static const String kPrefixedErrorsFlag = 'prefixed-errors';
-  static const String kDtdUrl = 'dtd-url';
   static const String kPrintDtd = 'print-dtd';
   static const String kQuietFlag = 'quiet';
   static const String kShowTestDeviceFlag = 'show-test-device';
@@ -152,12 +151,6 @@ class FlutterCommandRunner extends CommandRunner<void> {
       hide: !verboseHelp,
       help: 'Path to your "package_config.json" file.',
     );
-    argParser.addOption(
-      FlutterGlobalOptions.kDtdUrl,
-      help:
-          'The address of an existing Dart Tooling Daemon instance to be used by the Flutter CLI.',
-      hide: !verboseHelp,
-    );
     argParser.addFlag(
       FlutterGlobalOptions.kPrintDtd,
       negatable: false,

packages/flutter_tools/lib/src/widget_preview/dtd_services.dart

@@ -356,7 +356,6 @@
     "templates/widget_preview_scaffold/lib/src/widget_preview.dart.tmpl",
     "templates/widget_preview_scaffold/lib/src/widget_preview_rendering.dart.tmpl",
     "templates/widget_preview_scaffold/lib/src/controls.dart.tmpl",
-    "templates/widget_preview_scaffold/lib/src/dtd_services.dart.tmpl",
     "templates/widget_preview_scaffold/lib/src/generated_preview.dart.tmpl",
     "templates/widget_preview_scaffold/lib/src/utils.dart.tmpl",
     "templates/widget_preview_scaffold/pubspec.yaml.tmpl",

packages/flutter_tools/templates/template_manifest.json

@@ -13,7 +13,6 @@ import 'package:flutter/services.dart';
 import 'package:stack_trace/stack_trace.dart';
 
 import 'controls.dart';
-import 'dtd_services.dart';
 import 'generated_preview.dart';
 import 'utils.dart';
 import 'widget_preview.dart';
@@ -411,8 +410,6 @@ class PreviewAssetBundle extends PlatformAssetBundle {
 /// the preview scaffold project which prevents us from being able to use hot
 /// restart to iterate on this file.
 Future<void> mainImpl() async {
-  // TODO(bkonyi): store somewhere.
-  await WidgetPreviewScaffoldDtdServices().connect();
   runApp(_WidgetPreviewScaffold());
 }
 

packages/flutter_tools/templates/widget_preview_scaffold/lib/src/dtd_services.dart.tmpl

@@ -12,7 +12,6 @@ dependencies:
   flutter_test:
     sdk: flutter
   # These will be replaced with proper constraints after the template is hydrated.
-  dtd: any
   flutter_lints: any
   stack_trace: any
 

packages/flutter_tools/templates/widget_preview_scaffold/lib/src/widget_preview_rendering.dart.tmpl

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import 'package:file/memory.dart';
-import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/logger.dart';
 import 'package:flutter_tools/src/base/os.dart';
@@ -48,8 +47,6 @@ void main() {
           platform: platform,
           processManager: processManager,
         ),
-        processManager: FakeProcessManager.any(),
-        artifacts: Artifacts.test(fileSystem: fileSystem),
       );
       rootProject = FakeFlutterProject(
         projectRoot: 'some_project',

packages/flutter_tools/templates/widget_preview_scaffold/pubspec.yaml.tmpl

@@ -6,7 +6,6 @@ import 'dart:io' as io show IOOverrides;
 
 import 'package:args/command_runner.dart';
 import 'package:file_testing/file_testing.dart';
-import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/bot_detector.dart';
 import 'package:flutter_tools/src/base/common.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
@@ -81,8 +80,6 @@ void main() {
           logger: logger,
           platform: platform,
         ),
-        artifacts: Artifacts.test(),
-        processManager: FakeProcessManager.any(),
       ),
     );
     await runner.run(<String>['widget-preview', ...arguments]);