chore: revert stakeset handling in this subgraph and add new event parameter #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request removes the Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (15)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
👷 Deploy Preview for kleros-v2-testnet processing.
|
👷 Deploy Preview for kleros-v2-testnet-devtools processing.
|
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-testnet-devtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-university ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
kemuru
changed the title
|
Code Climate has analyzed commit 3397ab5 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
jaybuidl
force-pushed
the
feat/add-stakeset-total
branch
from
4554947 to
c399c03
Compare
jaybuidl
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the new _amountAllCourts to the StakeSet events
also reverts #1901 as discussed since we don't want to handle this entity in this subgraph due to entity overload since StakeSet is very frequent
frontend unaffected
PR-Codex overview
This PR focuses on updating the
StakeSetevent handling in the Kleros V2 subgraph, including changes to the event structure, the addition of a new parameter, and updates to related functions and schemas.Detailed summary
subgraph/package.jsonfrom0.12.0to0.13.0.StakeSettype inschema.graphqlto include an additional parameter.createStakeSetEventfunction to accept a new parameter_amountAllCourts.newStakeSetEventto include the new parameter.StakeSetEventtoStakeSet.StakeSetEntityinhandleStakeSetfunction.subgraph.yamlfiles to match the newStakeSetsignature.Summary by CodeRabbit
Summary by CodeRabbit
Refactor
StakeSetentity from theSortitionModule.StakeSetevent, enhancing data processing.Chores