-
Notifications
You must be signed in to change notification settings - Fork 49
Add commit reveal support #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code is looking good, but for some reason the Commit voting options' buttons are not working?
2024-01-09.20-15-59.mp4
I then tested creating a case in a court without Commit/reveal activated, voting directly works good:
2024-01-09.23-18-29.mp4
It works for me 🤔 did it prompt you to sign a message? try deleting the localstorage |
@alcercu Got this error when voting one option, and then because the subgraph was really slow I was able to click on another option which maybe was saved in localStorage and then at the time of reveal it errored since the options didn't match (but worked when deleting localStorage since it bruteforced the choice) ![]() |
Code Climate has analyzed commit 0165b1d and detected 190 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
PR-Codex overview
This PR focuses on adding new features and making improvements to the codebase.
Detailed summary:
isUndefined
function toutils/index.ts
catchShortMessage
function toutils/index.ts
useIsDesktop
hook tohooks/useIsDesktop.tsx
isLastRound
function inutils/isLastRound.ts
InfoCard
component tocomponents/InfoCard.tsx
PendingVotesBox
component topages/Cases/CaseDetails/Voting/PendingVotesBox.tsx
JustificationArea
component topages/Cases/CaseDetails/Voting/Classic/JustificationArea.tsx
HeroImage
component incomponents/HeroImage.tsx
contactDetails
function inconsts/eip712-messages.ts
VoteWithCommitExtraInfo
component incomponents/Popup/ExtraInfo/VoteWithCommitExtraInfo.tsx
useSigningAccount
hook tohooks/useSigningAccount.tsx
Filters
component incomponents/CasesDisplay/Filters.tsx
CasesGrid
component incomponents/CasesDisplay/CasesGrid.tsx
CasesFetcher
component inpages/Cases/CasesFetcher.tsx