-
Notifications
You must be signed in to change notification settings - Fork 49
feat(web): notification-system #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for kleros-v2-contracts failed.
|
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kemuru
reviewed
Oct 4, 2023
web/src/layout/Header/navbar/Menu/Settings/Notifications/FormContactDetails/index.tsx
Show resolved
Hide resolved
geaxed
reviewed
Oct 4, 2023
2b6735b
to
967e78f
Compare
…ty of the placeholder text
Code Climate has analyzed commit 788a48b and detected 112 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
jaybuidl
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on implementing a new feature for the navbar settings menu. The detailed summary of the changes includes:
SendMeNotifications
component and its related files.ISettings
,IHelp
, andIDappList
to thenavbar
module.Help
component to import theIHelp
interface.eip712-messages.ts
exporting a default object.EMAIL_REGEX
,TELEGRAM_REGEX
,ETH_ADDRESS_REGEX
, andETH_SIGNATURE_REGEX
to theconsts
module.generate:supabase
to thepackage.json
file.Menu
component to import theISettings
andIHelp
interfaces.NotificationSettings
to theSettings
module.FormContact
to theNotificationSettings
module.Settings
component to import theISettings
interface and use theNotificationSettings
component.uploadSettingsToSupabase.ts
exporting a functionuploadSettingsToSupabase
.FormContactDetails
component to import theISettings
interface and use theFormContact
component.package.json
file to add thesupabase
dependency and update thegenerate:hooks
script.