Skip to content

feat(web): notification-system #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 9, 2023
Merged

feat(web): notification-system #1210

merged 23 commits into from
Oct 9, 2023

Conversation

nhestrompia
Copy link
Contributor

@nhestrompia nhestrompia commented Aug 31, 2023

PR-Codex overview

This PR focuses on implementing a new feature for the navbar settings menu. The detailed summary of the changes includes:

  • Deleted the SendMeNotifications component and its related files.
  • Added new interfaces ISettings, IHelp, and IDappList to the navbar module.
  • Updated the Help component to import the IHelp interface.
  • Added a new file eip712-messages.ts exporting a default object.
  • Added new constants EMAIL_REGEX, TELEGRAM_REGEX, ETH_ADDRESS_REGEX, and ETH_SIGNATURE_REGEX to the consts module.
  • Added a new script generate:supabase to the package.json file.
  • Updated the Menu component to import the ISettings and IHelp interfaces.
  • Added a new component NotificationSettings to the Settings module.
  • Added a new component FormContact to the NotificationSettings module.
  • Updated the Settings component to import the ISettings interface and use the NotificationSettings component.
  • Added a new file uploadSettingsToSupabase.ts exporting a function uploadSettingsToSupabase.
  • Updated the FormContactDetails component to import the ISettings interface and use the FormContact component.
  • Updated the package.json file to add the supabase dependency and update the generate:hooks script.

The following files were skipped due to too many changes: web/src/layout/Header/navbar/Menu/Settings/Notifications/FormContactDetails/index.tsx, web/netlify/functions/update-settings.ts, web/src/types/supabase-notification.ts, web/src/types/supabase-datalake.ts, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for kleros-v2-contracts failed.

Name Link
🔨 Latest commit 0927267
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64f0967a77849100084e733e

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 788a48b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/652474d653243d00080ed214
😎 Deploy Preview https://deploy-preview-1210--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nhestrompia nhestrompia marked this pull request as ready for review September 10, 2023 18:59
@alcercu alcercu changed the base branch from dev to web-staging September 13, 2023 09:44
@jaybuidl jaybuidl linked an issue Sep 18, 2023 that may be closed by this pull request
Base automatically changed from web-staging to dev September 25, 2023 15:08
@jaybuidl jaybuidl requested review from alcercu and kemuru October 4, 2023 01:01
@jaybuidl jaybuidl force-pushed the feat(web)/notification-system branch 2 times, most recently from 2b6735b to 967e78f Compare October 9, 2023 18:14
@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023

Code Climate has analyzed commit 788a48b and detected 112 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 37
Style 73

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl merged commit 788a48b into dev Oct 9, 2023
@jaybuidl jaybuidl deleted the feat(web)/notification-system branch October 9, 2023 23:52
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration of the frontend with the email notification service.
4 participants