Skip to content

feat: integration of frontend with notification #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ptdatta
Copy link
Contributor

@ptdatta ptdatta commented Aug 8, 2023

fixes: #1079

Not done completely yet will do the backend part in the evening.

image

@netlify
Copy link

netlify bot commented Aug 8, 2023

‼️ Deploy request for kleros-v2 rejected.

Name Link
🔨 Latest commit 95bde7b

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 95bde7b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64d53797d3b14900080c2c31
😎 Deploy Preview https://deploy-preview-1118--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ptdatta
Copy link
Contributor Author

ptdatta commented Aug 9, 2023

Hey @jaybuidl @ , If you have time then please review my backend.

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2023

Code Climate has analyzed commit 95bde7b and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@ptdatta
Copy link
Contributor Author

ptdatta commented Aug 10, 2023

Hey @jaybuidl @alcercu I have completed the full integration of the notification system with the frontend.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jaybuidl
Copy link
Member

It was implemented separately but thanks for the PR anyway.

@jaybuidl jaybuidl closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration of the frontend with the email notification service.
2 participants