Skip to content

Use standard IPFS URIs #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaybuidl opened this issue Jan 24, 2024 · 0 comments · Fixed by #1471
Closed

Use standard IPFS URIs #1447

jaybuidl opened this issue Jan 24, 2024 · 0 comments · Fixed by #1471

Comments

@jaybuidl
Copy link
Member

jaybuidl commented Jan 24, 2024 •
edited
Loading

All the IPFS URIs we have been using since v1 do not conform with the RFC3986 specs for URIs.

❌ /ipfs/QmZ3Cmnip8bmFNruuTuCdxPymEjyK9VcQEyf2beDYcaHaK/metaEvidence.json
✅ ipfs://QmZ3Cmnip8bmFNruuTuCdxPymEjyK9VcQEyf2beDYcaHaK/metaEvidence.json

It should be relatively easy to fix, and we could even have a fallback for backward-compatibility.
@jaybuidl jaybuidl mentioned this issue Jan 25, 2024
Closed
@jaybuidl jaybuidl linked a pull request Jan 25, 2024 that will close this issue
Testing #1454
Closed
@jaybuidl jaybuidl removed a link to a pull request Jan 30, 2024
Testing #1454
Closed
@tractorss tractorss mentioned this issue Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(web): use-standard-ipfs-uris kleros/kleros-v2
1 participant
@jaybuidl