refactor(web): code-smells

Author: tractorss

web/src/context/AtlasProvider.tsx

@@ -18,9 +18,10 @@ interface IAtlasProvider {
 
 const Context = createContext<IAtlasProvider | undefined>(undefined);
 
-// eslint-disable-next-line
-// @ts-ignore
-const atlasUri = import.meta.env.REACT_APP_ATLAS_URI ?? "";
+const atlasUri: string = import.meta.env.REACT_APP_ATLAS_URI ?? "";
+if (!atlasUri) {
+  console.warn("REACT_APP_ATLAS_URI is not defined. Please check your environment variables.");
+}
 
 const AtlasProvider: React.FC<{ children?: React.ReactNode }> = ({ children }) => {
   const { address } = useAccount();
@@ -75,27 +76,24 @@ const AtlasProvider: React.FC<{ children?: React.ReactNode }> = ({ children }) =
   /**
    * @description authorise user and enable authorised calls
    */
-  const authoriseUser = useCallback(() => {
-    if (!address) return;
-    setIsSigningIn(true);
-    getNonce(atlasGqlClient, address)
-      .then((nonce) => {
-        const message = createMessage(address, chainId, nonce);
-        signMessageAsync({ message }).then((signature) => {
-          if (!isUndefined(signature)) {
-            loginUser(atlasGqlClient, { signature, message })
-              .then((token) => {
-                setAuthToken(token);
-              })
-              .finally(() => setIsSigningIn(false));
-          }
-        });
-      })
-      .catch((err) => {
-        // eslint-disable-next-line no-console
-        console.log(`authorise user error : ${err?.message}`);
-        setIsSigningIn(false);
-      });
+  const authoriseUser = useCallback(async () => {
+    try {
+      if (!address || !chainId) return;
+      setIsSigningIn(true);
+      const nonce = await getNonce(atlasGqlClient, address);
+      const message = createMessage(address, nonce, chainId);
+      const signature = await signMessageAsync({ message });
+
+      if (!signature) return;
+      const token = await loginUser(atlasGqlClient, { message, signature });
+
+      setAuthToken(token);
+    } catch (err: any) {
+      // eslint-disable-next-line
+      console.log("Authorize User Error : ", err?.message);
+    } finally {
+      setIsSigningIn(false);
+    }
   }, [address, chainId, setAuthToken, signMessageAsync, atlasGqlClient]);
 
   return (

web/src/utils/atlas/createMessage.ts

@@ -2,7 +2,7 @@ import { createSiweMessage } from "viem/siwe";
 
 import { DEFAULT_CHAIN } from "consts/chains";
 
-export const createMessage = (address: `0x${string}`, chainId: number = DEFAULT_CHAIN, nonce: string) => {
+export const createMessage = (address: `0x${string}`, nonce: string, chainId: number = DEFAULT_CHAIN) => {
   const domain = window.location.host;
   const origin = window.location.origin;
 

web/src/utils/atlas/getNonce.ts

@@ -24,8 +24,11 @@ export function getNonce(client: GraphQLClient, address: string): Promise<string
       .then((response) => response.nonce)
       .catch((errors) => {
         // eslint-disable-next-line no-console
-        console.log("get nonce error : ", { errors });
-        throw Error(`${errors?.response?.errors?.[0]?.message}`);
+        console.log("Error fetching nonce for address:", address, { errors });
+        const errorMessage = Array.isArray(errors?.response?.errors)
+          ? errors.response.errors[0]?.message
+          : "Error fetching nonce";
+        throw Error(errorMessage);
       }),
     {
       error: {

web/src/utils/atlas/loginUser.ts

@@ -32,8 +32,12 @@ export function loginUser(client: GraphQLClient, authData: AuthoriseUserData): P
       .then(async (response) => response.login.accessToken)
       .catch((errors) => {
         // eslint-disable-next-line no-console
-        console.log("authorise user error : ", { errors });
-        throw Error(`${errors?.response?.errors?.[0]?.message}`);
+        console.log("Authorization error:", { errors });
+
+        const errorMessage = Array.isArray(errors?.response?.errors)
+          ? errors.response.errors[0]?.message
+          : "Unknown error";
+        throw new Error(errorMessage);
       }),
     {
       pending: `Signing in User...`,