refactor: moved crosschain event to the gateway interface

Author: jaybuidl

contracts/src/arbitration/IArbitrableV2.sol

@@ -30,24 +30,6 @@ interface IArbitrableV2 {
         string _templateUri
     );
 
-    /// @dev To be emitted when a dispute is created to link the correct meta-evidence to the disputeID.
-    /// @param _arbitrator The arbitrator of the contract.
-    /// @param _arbitrableChainId The chain identifier where the Arbitrable contract is deployed.
-    /// @param _arbitrable The address of the Arbitrable contract.
-    /// @param _arbitrableDisputeID The identifier of the dispute in the Arbitrable contract.
-    /// @param _externalDisputeID An identifier created outside Kleros by the protocol requesting arbitration.
-    /// @param _templateId The identifier of the dispute template. Should not be used with _templateUri.
-    /// @param _templateUri IPFS path to the dispute template starting with '/ipfs/'. Should not be used with _templateId.
-    event CrossChainDisputeRequest(
-        IArbitratorV2 indexed _arbitrator,
-        uint256 _arbitrableChainId,
-        address indexed _arbitrable,
-        uint256 indexed _arbitrableDisputeID,
-        uint256 _externalDisputeID,
-        uint256 _templateId,
-        string _templateUri
-    );
-
     /// @dev To be raised when a ruling is given.
     /// @param _arbitrator The arbitrator giving the ruling.
     /// @param _disputeID The identifier of the dispute in the Arbitrator contract.

contracts/src/gateway/interfaces/IForeignGateway.sol

@@ -12,12 +12,29 @@ import "../../arbitration/IArbitrator.sol";
 import "@kleros/vea-contracts/src/interfaces/gateways/IReceiverGateway.sol";
 
 interface IForeignGateway is IArbitrator, IReceiverGateway {
+    /// @dev To be emitted when a dispute is sent to the IHomeGateway.
+    /// @param _arbitrator The arbitrator of the contract.
+    /// @param _arbitrableChainId The chain identifier where the Arbitrable contract is deployed.
+    /// @param _arbitrable The address of the Arbitrable contract.
+    /// @param _arbitrableDisputeID The identifier of the dispute in the Arbitrable contract.
+    /// @param _externalDisputeID An identifier created outside Kleros by the protocol requesting arbitration.
+    /// @param _templateId The identifier of the dispute template. Should not be used with _templateUri.
+    /// @param _templateUri IPFS path to the dispute template starting with '/ipfs/'. Should not be used with _templateId.
+    event CrossChainDisputeOutgoing(
+        IArbitratorV2 indexed _arbitrator,
+        uint256 _arbitrableChainId,
+        address indexed _arbitrable,
+        uint256 indexed _arbitrableDisputeID,
+        uint256 _externalDisputeID,
+        uint256 _templateId,
+        string _templateUri
+    );
+
     /// Relay the rule call from the home gateway to the arbitrable.
     function relayRule(address _messageSender, bytes32 _disputeHash, uint256 _ruling, address _forwarder) external;
 
     function withdrawFees(bytes32 _disputeHash) external;
 
-    // For cross-chain Evidence standard
     function disputeHashToForeignID(bytes32 _disputeHash) external view returns (uint256);
 
     function createDisputeERC20(

contracts/src/gateway/interfaces/IHomeGateway.sol

@@ -13,6 +13,24 @@ import "../../evidence/IMetaEvidence.sol";
 import "@kleros/vea-contracts/src/interfaces/gateways/ISenderGateway.sol";
 
 interface IHomeGateway is IArbitrable, IMetaEvidence, ISenderGateway {
+    /// @dev To be emitted when a dispute is received from the IForeignGateway.
+    /// @param _arbitrator The arbitrator of the contract.
+    /// @param _arbitrableChainId The chain identifier where the Arbitrable contract is deployed.
+    /// @param _arbitrable The address of the Arbitrable contract.
+    /// @param _arbitrableDisputeID The identifier of the dispute in the Arbitrable contract.
+    /// @param _externalDisputeID An identifier created outside Kleros by the protocol requesting arbitration.
+    /// @param _templateId The identifier of the dispute template. Should not be used with _templateUri.
+    /// @param _templateUri IPFS path to the dispute template starting with '/ipfs/'. Should not be used with _templateId.
+    event CrossChainDisputeIncoming(
+        IArbitratorV2 indexed _arbitrator,
+        uint256 _arbitrableChainId,
+        address indexed _arbitrable,
+        uint256 indexed _arbitrableDisputeID,
+        uint256 _externalDisputeID,
+        uint256 _templateId,
+        string _templateUri
+    );
+
     /// @dev Provide the same parameters as on the foreignChain while creating a dispute. Providing incorrect parameters will create a different hash than on the foreignChain and will not affect the actual dispute/arbitrable's ruling.
     /// @param _foreignChainID foreignChainId
     /// @param _foreignBlockHash foreignBlockHash
@@ -29,7 +47,8 @@ interface IHomeGateway is IArbitrable, IMetaEvidence, ISenderGateway {
         address _arbitrable
     ) external payable;
 
-    /// @dev Looks up the local home disputeID for a disputeHash. For cross-chain Evidence standard.
+    /// @dev Looks up the local home disputeID for a disputeHash.
     /// @param _disputeHash dispute hash
+    /// @return disputeID dispute identifier on the home chain
     function disputeHashToHomeID(bytes32 _disputeHash) external view returns (uint256);
 }