chore: fixed linting, using BiomeJS for JS/TS and solhint/prettier for Solidity

Author: jaybuidl

.eslintrc.json

@@ -1,5 +1,11 @@
 {
-    "files.associations": {
-        "*.css": "tailwindcss"
-    }
-}
+  "files.associations": {
+    "*.css": "tailwindcss"
+  },
+  "editor.defaultFormatter": "biomejs.biome",
+  "editor.formatOnSave": true,
+  "editor.codeActionsOnSave": {
+    "source.organizeImports.biome": true,
+    "quickfix.biome": true
+  }
+}

.prettierrc.json

@@ -0,0 +1,36 @@
+{
+    "$schema": "https://biomejs.dev/schemas/1.6.1/schema.json",
+    "organizeImports": {
+        "enabled": true
+    },
+    "linter": {
+        "enabled": true,
+        "rules": {
+            "recommended": true,
+            "correctness": {
+                "noUnusedVariables": "error"
+            },
+            "suspicious": {
+                "noExplicitAny": "error"
+            },
+            "style": {
+                "noNonNullAssertion": "error"
+            }
+        }
+    },
+    "formatter": {
+        "enabled": true,
+        "formatWithErrors": false,
+        "indentStyle": "space",
+        "indentWidth": 2,
+        "lineWidth": 100,
+        "ignore": []
+    },
+    "javascript": {
+        "formatter": {
+            "quoteStyle": "double",
+            "trailingComma": "es5",
+            "semicolons": "always"
+        }
+    }
+}

.vscode/settings.json

@@ -0,0 +1,21 @@
+{
+  "htmlWhitespaceSensitivity": "css",
+  "printWidth": 120,
+  "trailingComma": "es5",
+  "plugins": [
+    "prettier-plugin-solidity"
+  ],
+  "overrides": [
+    {
+      "files": "*.sol",
+      "options": {
+        "parser": "solidity-parse",
+        "printWidth": 120,
+        "tabWidth": 4,
+        "useTabs": false,
+        "singleQuote": false,
+        "bracketSpacing": false
+      }
+    }
+  ]
+}

biome/biome.base.json

@@ -4,12 +4,15 @@
     "prettier"
   ],
   "rules": {
+    "compiler-version": [
+      "error",
+      "^0.7.0 || ^0.8.0"
+    ],
     "prettier/prettier": "error",
     "max-line-length": "off",
     "check-send-result": "off",
     "not-rely-on-time": "off",
     "multiple-sends": "off",
-    "compiler-version": "off",
     "quotes": "warn",
     "func-visibility": [
       "error",
@@ -18,4 +21,4 @@
       }
     ]
   }
-}
+}

contracts/.prettierrc.json

@@ -0,0 +1,16 @@
+{
+    "extends": [
+        "../biome/biome.base.json"
+    ],
+    "files": {
+        "ignore": [
+            "src/**/*",
+            "test/**",
+            "typechain/**/*",
+            "node_modules/**",
+            "artifacts/**",
+            "cache/**",
+            "coverage/**"
+        ]
+    }
+}

.solhint.json renamed to contracts/.solhint.json

@@ -11,7 +11,9 @@ async function deployHomeProxy({ deployments, getChainId, ethers, config, networ
   const { deploy } = deployments;
   const chainId = await getChainId();
   const proxyConfigs = [arbitrumProxy, gnosisProxy, optimismProxy, polygonProxy, zksyncProxy];
-  const proxyConfig = proxyConfigs.find((config) => config.supportedChainIds.includes(Number(chainId)));
+  const proxyConfig = proxyConfigs.find((config) =>
+    config.supportedChainIds.includes(Number(chainId))
+  );
   if (!proxyConfig) {
     throw new Error(`No home proxy configuration supports chain ID ${chainId}`);
   }
@@ -44,6 +46,7 @@ async function deployHomeProxy({ deployments, getChainId, ethers, config, networ
 }
 
 deployHomeProxy.tags = ["HomeChain"];
-deployHomeProxy.skip = async ({ getChainId }) => !HOME_CHAIN_IDS.includes(Number(await getChainId()));
+deployHomeProxy.skip = async ({ getChainId }) =>
+  !HOME_CHAIN_IDS.includes(Number(await getChainId()));
 
 module.exports = deployHomeProxy;

contracts/biome.json

@@ -13,16 +13,26 @@ const loserAppealPeriodMultiplier = 5000;
 async function getHomeDeployments({ companionNetworks, homeNetworkName, homeChainId }) {
   let homeNetwork;
   for await (const [key, network] of Object.entries(companionNetworks))
-    if (key.startsWith("home") && String(await network.getChainId()) === String(homeChainId)) homeNetwork = network;
+    if (key.startsWith("home") && String(await network.getChainId()) === String(homeChainId))
+      homeNetwork = network;
   if (!homeNetwork) throw new Error(`Home network ${homeNetworkName} not configured correctly`);
   return homeNetwork.deployments;
 }
 
-async function deployForeignProxy({ deployments, getChainId, ethers, companionNetworks, config, network }) {
+async function deployForeignProxy({
+  deployments,
+  getChainId,
+  ethers,
+  companionNetworks,
+  config,
+  network,
+}) {
   const homeNetworkName = process.env.HOME_NETWORK;
   if (!homeNetworkName) throw new Error("HOME_NETWORK environment variable must be set");
   const proxyConfigs = [arbitrumProxy, gnosisProxy, optimismProxy, polygonProxy, zksyncProxy];
-  const proxyConfig = proxyConfigs.find((config) => config.supportedHomeChains.includes(homeNetworkName));
+  const proxyConfig = proxyConfigs.find((config) =>
+    config.supportedHomeChains.includes(homeNetworkName)
+  );
   if (!proxyConfig) {
     throw new Error(`No foreign proxy configuration supports home network ${homeNetworkName}`);
   }
@@ -37,7 +47,11 @@ async function deployForeignProxy({ deployments, getChainId, ethers, companionNe
   const parameters = proxyConfig.foreignParameters[homeNetworkName];
   const homeProxyName = proxyConfig.getHomeProxyName(homeNetworkName);
   const homeChainId = config.networks[homeNetworkName].chainId;
-  const homeDeployments = await getHomeDeployments({ companionNetworks, homeNetworkName, homeChainId });
+  const homeDeployments = await getHomeDeployments({
+    companionNetworks,
+    homeNetworkName,
+    homeChainId,
+  });
   const homeProxy = await homeDeployments.get(homeProxyName).then((homeProxy) => homeProxy.address);
 
   const foreignProxy = await proxyConfig.deployForeignProxy({
@@ -56,6 +70,7 @@ async function deployForeignProxy({ deployments, getChainId, ethers, companionNe
 }
 
 deployForeignProxy.tags = ["ForeignChain"];
-deployForeignProxy.skip = async ({ getChainId }) => !FOREIGN_CHAIN_IDS.includes(Number(await getChainId()));
+deployForeignProxy.skip = async ({ getChainId }) =>
+  !FOREIGN_CHAIN_IDS.includes(Number(await getChainId()));
 
 module.exports = deployForeignProxy;

contracts/deploy/01-home-proxy.js

@@ -15,7 +15,16 @@ const foreignParameters = {
   },
 };
 
-async function deployForeignProxy({ deploy, from, parameters, homeNetworkName, homeProxy, arbitrator, courts, multipliers }) {
+async function deployForeignProxy({
+  deploy,
+  from,
+  parameters,
+  homeNetworkName,
+  homeProxy,
+  arbitrator,
+  courts,
+  multipliers,
+}) {
   const { numberOfJurors, inbox } = parameters;
   const metaEvidence = getMetaEvidenceCID(homeNetworkName);
   const arbitratorExtraData = encodeExtraData(courts.oracle, numberOfJurors);