Fix broadcast receiver (#3168)

* Update broadcastReceiver

* Undo unnecessary changes.

* Update broadcast.py

Author: Novfensec

pythonforandroid/recipes/android/src/android/broadcast.py

@@ -1,9 +1,12 @@
 # -------------------------------------------------------------------
 # Broadcast receiver bridge
-
+import logging
 from jnius import autoclass, PythonJavaClass, java_method
 from android.config import JAVA_NAMESPACE, JNI_NAMESPACE, ACTIVITY_CLASS_NAME, SERVICE_CLASS_NAME
 
+logger = logging.getLogger("BroadcastReceiver")
+logger.setLevel(logging.DEBUG)
+
 
 class BroadcastReceiver(object):
 
@@ -22,6 +25,7 @@ def onReceive(self, context, intent):
     def __init__(self, callback, actions=None, categories=None):
         super().__init__()
         self.callback = callback
+        self._is_registered = False
 
         if not actions and not categories:
             raise Exception('You need to define at least actions or categories')
@@ -58,15 +62,36 @@ def _expand_partial_name(partial_name):
             self.receiver_filter.addCategory(x)
 
     def start(self):
-        Handler = autoclass('android.os.Handler')
+
+        if hasattr(self, 'handlerthread') and self.handlerthread.isAlive():
+            logger.debug("HandlerThread already running, skipping start")
+            return
+
+        HandlerThread = autoclass('android.os.HandlerThread')
+        self.handlerthread = HandlerThread('handlerthread')
         self.handlerthread.start()
+
+        if self._is_registered:
+            logger.info("Already registered.")
+            return
+
+        Handler = autoclass('android.os.Handler')
         self.handler = Handler(self.handlerthread.getLooper())
         self.context.registerReceiver(
             self.receiver, self.receiver_filter, None, self.handler)
+        self._is_registered = True
 
     def stop(self):
-        self.context.unregisterReceiver(self.receiver)
-        self.handlerthread.quit()
+        try:
+            self.context.unregisterReceiver(self.receiver)
+            self._is_registered = False
+        except Exception as e:
+            logger.error("unregisterReceiver failed: %s", e)
+
+        if hasattr(self, 'handlerthread'):
+            self.handlerthread.quitSafely()
+            self.handlerthread = None
+            self.handler = None
 
     @property
     def context(self):