Skip to content

Commit 59c240f

Browse files
Make caching feature node version agnostic
1 parent 543ccf0 commit 59c240f

File tree

2 files changed

+21
-20
lines changed

2 files changed

+21
-20
lines changed

.github/workflows/test.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,6 @@ on:
66
pull_request:
77
branches: [main]
88

9-
env:
10-
# This is required to support GLIB versions present in amazon linux 2. Can be removed once amazon linux 2 is 💀
11-
# More info
12-
# - https://github.com/actions/checkout/issues/1809#issuecomment-2208202462
13-
# - https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
14-
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
15-
169
jobs:
1710
test_python_installation:
1811
strategy:
@@ -32,7 +25,9 @@ jobs:
3225
run: |
3326
yum install -y git tar gzip sudo which
3427
35-
- uses: actions/checkout@v3
28+
- name: Checkout
29+
run: |
30+
git clone --depth 1 -b "${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}" "https://github.com/${GITHUB_REPOSITORY}.git" .
3631
3732
- name: Install python
3833
uses: ./
@@ -79,7 +74,9 @@ jobs:
7974
- name: Setup runner
8075
run: yum install -y git tar gzip sudo
8176

82-
- uses: actions/checkout@v3
77+
- name: Checkout
78+
run: |
79+
git clone --depth 1 -b "${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}" "https://github.com/${GITHUB_REPOSITORY}.git" .
8380
8481
- name: Install python
8582
uses: ./
@@ -105,7 +102,9 @@ jobs:
105102
run: |
106103
yum install -y git tar gzip sudo
107104
108-
- uses: actions/checkout@v3
105+
- name: Checkout
106+
run: |
107+
git clone --depth 1 -b "${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}" "https://github.com/${GITHUB_REPOSITORY}.git" .
109108
110109
- name: Install python
111110
uses: ./
@@ -129,7 +128,9 @@ jobs:
129128
run: |
130129
yum install -y git tar gzip sudo
131130
132-
- uses: actions/checkout@v3
131+
- name: Checkout
132+
run: |
133+
git clone --depth 1 -b "${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}" "https://github.com/${GITHUB_REPOSITORY}.git" .
133134
134135
- name: Create python version file
135136
run: |

action.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,17 @@ runs:
3232
exact_python_version="${{ steps.find-exact-python-version.outputs.exact_python_version }}"
3333
echo "installation_directory=${HOME}/.setup-python-amazon-linux/.python-versions/${exact_python_version}" >> $GITHUB_OUTPUT
3434
35-
- name: Cache
36-
id: cache-python
37-
uses: actions/cache@v3
38-
if: inputs.cache == 'true'
39-
with:
40-
path: ${{ steps.set-installation-directory.outputs.installation_directory }}
41-
key: python-${{ steps.find-exact-python-version.outputs.exact_python_version }}-${{ runner.arch }}
35+
# - name: Cache
36+
# id: cache-python
37+
# uses: actions/cache@v3
38+
# if: inputs.cache == 'true'
39+
# with:
40+
# path: ${{ steps.set-installation-directory.outputs.installation_directory }}
41+
# key: python-${{ steps.find-exact-python-version.outputs.exact_python_version }}-${{ runner.arch }}
4242

4343
- id: setup-python
4444
shell: bash
45-
if: inputs.cache == 'false' || (inputs.cache == 'true' && steps.cache-python.outputs.cache-hit != 'true')
45+
# if: inputs.cache == 'false' || (inputs.cache == 'true' && steps.cache-python.outputs.cache-hit != 'true')
4646
run: |
4747
installation_directory="${{ steps.set-installation-directory.outputs.installation_directory }}"
4848
exact_python_version="${{ steps.find-exact-python-version.outputs.exact_python_version }}"
@@ -61,7 +61,7 @@ runs:
6161
6262
echo "The following python binaries are now available in the PATH"
6363
ls "${installation_directory}/bin"
64-
64+
6565
echo "Linking python libraries..."
6666
ls "${installation_directory}/lib"
6767
sudo ldconfig "${installation_directory}/lib"

0 commit comments

Comments
 (0)