Skip to content

Commit d2ab7f0

Browse files
tititiou36Kalle Valo
authored andcommitted
mwifiex: Do not use GFP_KERNEL in atomic context
A possible call chain is as follow: mwifiex_sdio_interrupt (sdio.c) --> mwifiex_main_process (main.c) --> mwifiex_process_cmdresp (cmdevt.c) --> mwifiex_process_sta_cmdresp (sta_cmdresp.c) --> mwifiex_ret_802_11_scan (scan.c) --> mwifiex_parse_single_response_buf (scan.c) 'mwifiex_sdio_interrupt()' is an interrupt function. Also note that 'mwifiex_ret_802_11_scan()' already uses GFP_ATOMIC. So use GFP_ATOMIC instead of GFP_KERNEL when memory is allocated in 'mwifiex_parse_single_response_buf()'. Fixes: 7c6fa2a ("mwifiex: use cfg80211 dynamic scan table and cfg80211_get_bss API") or Fixes: 601216e ("mwifiex: process RX packets in SDIO IRQ thread directly") Signed-off-by: Christophe JAILLET <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 2c762ee commit d2ab7f0

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/marvell/mwifiex

1 file changed

+1
-1
lines changed

drivers/net/wireless/marvell/mwifiex/scan.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1889,7 +1889,7 @@ mwifiex_parse_single_response_buf(struct mwifiex_private *priv, u8 **bss_info,
18891889
chan, CFG80211_BSS_FTYPE_UNKNOWN,
18901890
bssid, timestamp,
18911891
cap_info_bitmap, beacon_period,
1892-
ie_buf, ie_len, rssi, GFP_KERNEL);
1892+
ie_buf, ie_len, rssi, GFP_ATOMIC);
18931893
if (bss) {
18941894
bss_priv = (struct mwifiex_bss_priv *)bss->priv;
18951895
bss_priv->band = band;

0 commit comments

Comments
 (0)