Skip to content

Commit 44f4daf

Browse files
uudiinmartinkpetersen
authored andcommitted
scsi: csiostor: Fix wrong return value in csio_hw_prep_fw()
On an error exit path, a negative error code should be returned instead of a positive return value. Link: https://lore.kernel.org/r/[email protected] Fixes: f40e74f ("csiostor:firmware upgrade fix") Cc: Praveen Madhavan <[email protected]> Signed-off-by: Tianjia Zhang <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent ca4fb89 commit 44f4daf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/scsi/csiostor/csio_hw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2384,7 +2384,7 @@ static int csio_hw_prep_fw(struct csio_hw *hw, struct fw_info *fw_info,
23842384
FW_HDR_FW_VER_MICRO_G(c), FW_HDR_FW_VER_BUILD_G(c),
23852385
FW_HDR_FW_VER_MAJOR_G(k), FW_HDR_FW_VER_MINOR_G(k),
23862386
FW_HDR_FW_VER_MICRO_G(k), FW_HDR_FW_VER_BUILD_G(k));
2387-
ret = EINVAL;
2387+
ret = -EINVAL;
23882388
goto bye;
23892389
}
23902390

0 commit comments

Comments
 (0)