Skip to content

Define fault injection job #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Define fault injection job #1151

merged 2 commits into from
May 22, 2025

Conversation

crazoes
Copy link

@crazoes crazoes commented May 13, 2025

Add fault injection configs to chromeos and schedular yamls

@crazoes crazoes requested a review from laura-nao May 13, 2025 20:35
@crazoes crazoes self-assigned this May 13, 2025
@crazoes crazoes requested a review from nuclearcat May 13, 2025 20:35
@crazoes crazoes force-pushed the fault-injection branch 3 times, most recently from 0f3928d to 565b4c9 Compare May 19, 2025 14:35
Shreeya Patel added 2 commits May 20, 2025 19:12
Add fault injection configs to chromeos and schedular yamls

Signed-off-by: Shreeya Patel <[email protected]>
We need a custom build for running fault injection tests,
hence add a new kbuild entry for it.

Signed-off-by: Shreeya Patel <[email protected]>
@crazoes crazoes force-pushed the fault-injection branch from 565b4c9 to 784317c Compare May 20, 2025 13:44
Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll wait with merging this change until test run is completed

Checkout NodeID: 682e26d7cb2dab5edbc5777f triggered with:

./tools/kci-maintainer --checkout -u https://chromium.googlesource.com/chromiumos/third_party/kernel.git -b chromeos-6.6 --latest-commit -f kbuild-gcc-12-x86-chromeos-daily-intel-fault-injection -f fault-injection-x86-intel-cros-kernel

@crazoes
Copy link
Author

crazoes commented May 22, 2025

@pawiecz thanks for triggering the test. Before merging this PR, can you please also review this PR and merge it?

Once we have that change in kernelci-core, we should be good to merge this one as well.

@pawiecz
Copy link
Contributor

pawiecz commented May 22, 2025

@pawiecz thanks for triggering the test. Before merging this PR, can you please also review this PR and merge it?

Once we have that change in kernelci-core, we should be good to merge this one as well.

I'm more than happy to approve your PR to the core repo (done) but I don't have permissions to merge patches there 😢

@nuclearcat Please take a look when you get a chance

@pawiecz
Copy link
Contributor

pawiecz commented May 22, 2025

Thanks @nuclearcat for merging related PR

These changes have been successfully verified (even though end result is marked as incomplete on Maestro side everything worked fine)

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawiecz pawiecz added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit 1c78214 May 22, 2025
4 checks passed
@pawiecz pawiecz deleted the fault-injection branch May 22, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants