src: lava_callback: handle artifacts uploaded from test jobs #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @a-wai could it be solved by #1140 ? |
|
@a-wai Got it, that makes sense, thanks! |
|
Is it tested anyhow, or maybe how i can help with testing? |
|
@nuclearcat only manually tested for now, we should have more results soon now that I've (hopefully) fixed #1131 |
a-wai
force-pushed
the
lava-callback-handle-artifacts
branch
2 times, most recently
from
57ceeed to
34c8774
Compare
a-wai
force-pushed
the
lava-callback-handle-artifacts
branch
4 times, most recently
from
4d75674 to
9bf2dcb
Compare
Test jobs might need to upload artifacts directly from LAVA (this is needed e.g. for GCOV data when checking for code coverage), but we currently have no way to add those artifacts to the corresponding node. Add such a feature in a rather generic way, so jobs can provide both the artifact name and its URL through a specially-formatted result entry: artifact-upload:<artifact name>:<artifact URL> Therefore, all test results starting with `artifact-upload:` will be processed and stored in the corresponding node's `artifacts` dict, with `<artifact name>` being the entry key and `<artifact URL>` being its value. Signed-off-by: Arnaud Ferraris <[email protected]>
a-wai
force-pushed
the
lava-callback-handle-artifacts
branch
from
9bf2dcb to
a4b7119
Compare
|
Coverage data successfully retrieved on the latest staging run, see this node for an example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test jobs might need to upload artifacts directly from LAVA (this is needed e.g. for GCOV data when checking for code coverage), but we currently have no way to add those artifacts to the corresponding node.
Add such a feature in a rather generic way, so jobs can provide both the artifact name and its URL through a specially-formatted result entry:
artifact-upload:<artifact name>:<artifact URL>Therefore, all test results starting with
artifact-upload:will be processed and stored in the corresponding node'sartifactsdict, with<artifact name>being the entry key and<artifact URL>being its value.Depends on #1159 & kernelci/kernelci-core#2878