Skip to content

Commit 360f898

Browse files
Wer-Wolfdavem330
authored andcommitted
lib8390: Use netif_msg_init to initialize msg_enable bits
Use netif_msg_init() to process param settings and use only the proper initialized value of ei_local->msg_level for later processing; Signed-off-by: Armin Wolf <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7a333af commit 360f898

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

drivers/net/ethernet/8390/lib8390.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,10 @@ static void do_set_multicast_list(struct net_device *dev);
113113
static void __NS8390_init(struct net_device *dev, int startp);
114114

115115
static unsigned version_printed;
116-
static u32 msg_enable;
117-
module_param(msg_enable, uint, 0444);
116+
static int msg_enable;
117+
static const int default_msg_level = (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_RX_ERR |
118+
NETIF_MSG_TX_ERR);
119+
module_param(msg_enable, int, 0444);
118120
MODULE_PARM_DESC(msg_enable, "Debug message level (see linux/netdevice.h for bitmap)");
119121

120122
/*
@@ -974,14 +976,14 @@ static void ethdev_setup(struct net_device *dev)
974976
{
975977
struct ei_device *ei_local = netdev_priv(dev);
976978

977-
if ((msg_enable & NETIF_MSG_DRV) && (version_printed++ == 0))
978-
pr_info("%s", version);
979-
980979
ether_setup(dev);
981980

982981
spin_lock_init(&ei_local->page_lock);
983982

984-
ei_local->msg_enable = msg_enable;
983+
ei_local->msg_enable = netif_msg_init(msg_enable, default_msg_level);
984+
985+
if (netif_msg_drv(ei_local) && (version_printed++ == 0))
986+
pr_info("%s", version);
985987
}
986988

987989
/**

0 commit comments

Comments
 (0)