selftests/bpf: Fix selftest btf_tag/btf_type_tag_percpu_vmlinux_helper failure #5387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 90b83ef |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1be7719 to
18af9fe
Compare
|
Upstream branch: 90b83ef |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/967432=>bpf-next
branch
from
e6a92d3 to
ff1a1b2
Compare
|
Upstream branch: 90b83ef |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/967432=>bpf-next
branch
from
ff1a1b2 to
5387cef
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
18af9fe to
653831c
Compare
…r failure Ihor Solodrai reported selftest 'btf_tag/btf_type_tag_percpu_vmlinux_helper' failure ([1]) during 6.16 merge window. The failure log: ... 7: (15) if r0 == 0x0 goto pc+1 ; R0=ptr_css_rstat_cpu() ; *(volatile int *)rstat; @ btf_type_tag_percpu.c:68 8: (61) r1 = *(u32 *)(r0 +0) cannot access ptr member updated_children with moff 0 in struct css_rstat_cpu with off 0 size 4 Two changes are needed. First, 'struct cgroup_rstat_cpu' needs to be replaced with 'struct css_rstat_cpu' to be consistent with new data structure. Second, layout of 'css_rstat_cpu' is changed compared to 'cgroup_rstat_cpu'. The first member becomes a pointer so the bpf prog needs to do 8-byte load instead of 4-byte load. [1] https://lore.kernel.org/bpf/[email protected]/ Cc: Ihor Solodrai <[email protected]> Cc: JP Kobryn <[email protected]> Signed-off-by: Yonghong Song <[email protected]> Acked-by: JP Kobryn <[email protected]>
|
Upstream branch: bb1556e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/967432=>bpf-next
branch
from
5387cef to
117ec32
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=967432 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix selftest btf_tag/btf_type_tag_percpu_vmlinux_helper failure
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=967432