Skip to content

Corrected wrong example #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Corrected wrong example #57

wants to merge 1 commit into from

Conversation

xplosionmind
Copy link

The second example about adding custom rels was identical to the former, while another attribute should have been added.

@xplosionmind
corrected wrong example
fdb838e 
The second example about adding custom `rel`s was identical to the former, while another attribute should have been added.
@keithmifsud
Copy link
Owner

@xplosionmind can you fix the checks issues, please?If so, I'll add it to v2,1

@xplosionmind
Copy link
Author

xplosionmind commented Mar 24, 2021 •
edited
Loading

can you fix the checks issues, please?

Sorry, honestly, I have no idea how to understand the error, its source and how to fix it. I forked the repository and simply changed the README.

I never stumbled upon Travis-CI before and it is the first time I have a PR fail. Could you give me some insights?
Thank you very much ❤️

@keithmifsud
Copy link
Owner

Hi @xplosionmind ... I think you can just ignore these files:

Rubocop 0.71.0
vendor/bundle/ruby/2.5.0/gems/jekyll-4.2.0/.rubocop.yml: Layout/LineLength has the wrong namespace - should be Metrics
vendor/bundle/ruby/2.5.0/gems/jekyll-4.2.0/.rubocop.yml: Lint/SelfAssignment has the wrong namespace - should be Style
Configuration file not found: /home/travis/build/keithmifsud/jekyll-target-blank/vendor/bundle/ruby/2.5.0/gems/jekyll-4.2.0/.rubocop_todo.yml
The command "scripts/cibuild" exited with 2.

from rubocop because they're bundles and outside our codebase.

https://docs.rubocop.org/rubocop/configuration.html#includingexcluding-files

@prplecake
Copy link
Contributor

I think this is jekyll-target-blank's bug. We're using version 0.71.0 of Rubocop where the latest version is 1.26. Furthermore, Metrics/LineLength was moved to Layout/LineLength in Rubocop version 0.78.0

prplecake added a commit to prplecake/jekyll-target-blank that referenced this pull request Mar 11, 2022
@prplecake
Fix quality checks
647814f 
- Update Rubocop to a version > 1
- Also updates rubocop-jekyll to 0.12.0
- Don't inherit .rubocop.yml from jekyll (.rubocop_todo.yml is not
  installed with a Gem, so that file is always missing)
- s/Metrics/Layout (keithmifsud#57 (comment))
prplecake added a commit to prplecake/jekyll-target-blank that referenced this pull request Mar 11, 2022
@prplecake
Fix quality checks
c1ffbdd 
- Update Rubocop to a version > 1
- Also updates rubocop-jekyll to 0.12.0
- Don't inherit .rubocop.yml from jekyll (.rubocop_todo.yml is not
  installed with a Gem, so that file is always missing)
- s/Metrics/Layout (keithmifsud#57 (comment))
@prplecake prplecake mentioned this pull request Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xplosionmind @keithmifsud @prplecake