Skip to content

Update docs for Psr18Client #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Mar 23, 2021
Merged

Update docs for Psr18Client #260

merged 44 commits into from
Mar 23, 2021

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Mar 23, 2021

As I wrote in #257 I would create another PR for migrate to the new Psr18Client. This PR also:

  • adds a CHANGELOG.md for better documenting all changes
  • adds the docs/migrate-to-psr18client.md with the migration guide
  • move the example.php to docs/usage.md with more information and examples
  • remove the redundant section about impersonate user in README.md

Art4 added 30 commits March 17, 2021 10:33
@Art4
Create Psr18Client
e191d06
@Art4
Create interfaces for Client and Api
d77823c 
Move Api instantiation into trait
@Art4
Issue Api uses getApi on client
aea4a86
@Art4
Add new request methods to ClientInterface
4f1592d
@Art4
Add tests for new ClientInterface methods
9c6c49d
@Art4
Add test for requestGet method
2898164
@Art4
Test Request created by client
2a4b5e1
@Art4
Move tests for request generation into integration test
f9e0c69
@Art4
Improve integration tests
41abcd5
@Art4
Move clients into own namespace, rename interfaces
99372fa
@Art4
Implement auth with username:pwd or access key
8332c0c
@Art4
move Api interface
b28f771
@Art4
add content-type header
85f0886
@Art4
Let AbstractApi consume new Client interface
ea29ba2 
Move json- and XML-decoding into AbtractApi
Fix and improve all tests
@Art4
test exception messages
ccf5fa7
@Art4
Implement impersonate user
95cd581
@Art4
Test correct response data in client
3b4862b
@Art4
Add tests for AbstractApi
4ebe9b5
@Art4
Add tests for decoding in AbstractApi
24cd24e 
Simplify error messages in JSON decoding
@Art4
Test XML decoding on post, put and delete requests
8bd1c31
@Art4
Add integration tests for POST, PUT and DELETE
0fb1406
@Art4
Test file upload with content and file path
bb3624b
@Art4
Remove debug code
7cd5e6d
@Art4
Update example.php to use new client interface
be223f7
@Art4
Update README.md
c808f1b
@Art4
Merge branch 'master' into add-psr-18-client
9cac7d1
@Art4
Create usage docs
3202c90
@Art4
Add docs for user impersonation and curl options, improve language
dec300a
@Art4
Improve AbstractApi, remove obvious docblocks
22cfb73 
rename $data to $body
rename $decode to $decodeIfJson
@Art4
Rephrase trait description, add @internal
0a69982
@Art4 Art4 requested a review from kbsali March 23, 2021 14:20
kbsali
kbsali approved these changes Mar 23, 2021
View reviewed changes
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! 💪

@kbsali kbsali merged commit 39285b0 into kbsali:master Mar 23, 2021
@Art4 Art4 deleted the update-docs-for-psr18client branch March 23, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbsali kbsali kbsali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Art4 @kbsali