Improve tests for Wiki::remove

Author: Art4

tests/Behat/Bootstrap/WikiContextTrait.php

@@ -69,9 +69,9 @@ public function iUpdateTheWikiPageWithNameAndProjectIdentifierWithTheFollowingDa
     }
 
     /**
-     * @When I delete the wiki page with name :pageName and project identifier :identifier
+     * @When I remove the wiki page with name :pageName and project identifier :identifier
      */
-    public function iDeleteTheWikiPageWithNameAndProjectIdentifier(string $pageName, string $identifier)
+    public function iRemoveTheWikiPageWithNameAndProjectIdentifier($pageName, $identifier)
     {
         /** @var Wiki */
         $api = $this->getNativeCurlClient()->getApi('wiki');

tests/Behat/features/wiki.feature

@@ -234,13 +234,13 @@ Feature: Interacting with the REST API for wikis
         And the returned data is exactly ""
 
     @wiki
-    Scenario: Deleting a wiki page
+    Scenario: Removing a wiki page
         Given I have a "NativeCurlClient" client
         And I create a project with name "Test Project" and identifier "test-project"
         And I create a wiki page with name "Test Page" and project identifier "test-project" with the following data
             | property          | value                |
             | text              | # My first wiki page |
-        When I delete the wiki page with name "Test Page" and project identifier "test-project"
+        When I remove the wiki page with name "Test Page" and project identifier "test-project"
         Then the response has the status code "204"
         And the response has an empty content type
         And the response has the content ""

tests/Unit/Api/Wiki/RemoveTest.php

@@ -0,0 +1,61 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Redmine\Tests\Unit\Api\Wiki;
+
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+use Redmine\Api\Wiki;
+use Redmine\Tests\Fixtures\AssertingHttpClient;
+
+#[CoversClass(Wiki::class)]
+class RemoveTest extends TestCase
+{
+    /**
+     * @dataProvider getRemoveData
+     */
+    #[DataProvider('getRemoveData')]
+    public function testRemoveReturnsCorrectResponse($id, $page, $expectedPath, $responseCode, $response)
+    {
+        $client = AssertingHttpClient::create(
+            $this,
+            [
+                'DELETE',
+                $expectedPath,
+                'application/xml',
+                '',
+                $responseCode,
+                '',
+                $response
+            ]
+        );
+
+        // Create the object under test
+        $api = new Wiki($client);
+
+        // Perform the tests
+        $this->assertSame('', $api->remove($id, $page));
+    }
+
+    public static function getRemoveData(): array
+    {
+        return [
+            'test with integer' => [
+                5,
+                'test',
+                '/projects/5/wiki/test.xml',
+                204,
+                '',
+            ],
+            'test with special chars in page name' => [
+                5,
+                'test page',
+                '/projects/5/wiki/test+page.xml',
+                204,
+                '',
+            ],
+        ];
+    }
+}

tests/Unit/Api/WikiTest.php

@@ -114,29 +114,4 @@ public function testAllReturnsClientGetResponseWithParameters()
         // Perform the tests
         $this->assertSame($expectedReturn, $api->all(5, $parameters));
     }
-
-    /**
-     * Test remove().
-     */
-    public function testRemoveCallsDelete()
-    {
-        // Test values
-        $response = 'API Response';
-
-        // Create the used mock objects
-        $client = $this->createMock(Client::class);
-        $client->expects($this->once())
-            ->method('requestDelete')
-            ->with('/projects/5/wiki/test.xml')
-            ->willReturn(true);
-        $client->expects($this->once())
-            ->method('getLastResponseBody')
-            ->willReturn($response);
-
-        // Create the object under test
-        $api = new Wiki($client);
-
-        // Perform the tests
-        $this->assertSame($response, $api->remove(5, 'test'));
-    }
 }