Commonjs #2
Merged
Commonjs #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawan16
added a commit
that referenced
this pull request
Jul 9, 2015
|
Hi Aaron, Thanks for your interest and your contribution ! For sure, it will be very helpful. Indeed, I don't have a clear idea how to test it. Maybe using some kind of mock the window/module variables... |
|
No problem. Actually, this PR might be premature. browserify can nicely bundle this version up with the rest of my code, but rendering sub-states is not working. I'll keep on poking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great work with this router. This PR exposes mx via commonjs so it can be packaged with browserify.
I'm not sure how to write a test for this (or that it is necessary), so if you have a suggestion I'd love to hear it.