Update typescript and devDependencies #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a bit more concise js output from TypeScript. My main intention was to remove rollup from this project as tsc supports umd output too. But for some reason the umd output doesnt seem to work with the tests as the import seems to be different with rollup. Dropping support for old JS and using ES modules rather than umd would simplify the toolchain here. ES modules are supported from Node.js 12 which is also many years out of support already. All browsers support ES modules for years now so requiring ES modules shouldnt be a big problem. But for this PR I stayed with bumping the dependencies.
generalmimon
requested changes
Mar 19, 2025
Comment on lines
-32
to
+34
| "KaitaiStream.js", | ||
| "KaitaiStream.d.ts", | ||
| "index.d.ts" | ||
| "*.js", | ||
| "*.d.ts" |
There was a problem hiding this comment.
Actually, I don't think this the best idea - it makes it possible (and easy) to accidentally publish some other .js file. Let's keep it explicit.
generalmimon
added a commit
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a bit more concise JS output from TypeScript.
My main intention was to remove rollup from this project as tsc supports UMD output too. But for some reason the UMD output doesn't seem to work with the tests as the import seems to be different with rollup. Dropping support for old JS and using ES modules rather than UMD would simplify the toolchain here.
ES modules are supported from Node.js 12 which is also many years out of support already. All browsers support ES modules for years now so requiring ES modules shouldn't be a big problem. But for this PR I stayed with bumping the dependencies.
As the initial TypeScript implementation came from @Tschrock in #25 I'll tag you here too as you might be interested.