Add comments and rename a variable for readability

Author: consideRatio

.github/workflows/test.yaml

@@ -103,7 +103,12 @@ jobs:
           jupyter lab build --minimize=False --debug
 
       - name: Check the lab extension
-        if: ${{ !(matrix.jupyterlab-version == '2' && matrix.python-version == '3.11') }}
+        # We test the labextension thoroughly in the acceptance tests below, so
+        # we have conditionally disabled this basic check is to avoid issues in
+        # jupyterlab.browser_check with jupyterlab 2 and a modern version of
+        # python (3.11+).
+        #
+        if: ${{ !(matrix.jupyterlab-version == '2' && startsWith(matrix.python-version, '3.1')) }}
         run: |
           jupyter labextension list
           jupyter labextension list 2>&1 | grep -ie '@jupyterlab/server-proxy.*OK.*'

tests/acceptance/test_acceptance.py

@@ -7,12 +7,11 @@
 
 HERE = Path(__file__).parent
 OUTPUT = HERE.parent.parent / "build/robot"
-SERVER_INFO = None
-LAB_INFO = None
+JUPYTER_SERVER_INFO = None
 
 try:
     import jupyter_server
-    SERVER_INFO = jupyter_server.version_info
+    JUPYTER_SERVER_INFO = jupyter_server.version_info
 except ImportError:
     pass
 
@@ -23,7 +22,9 @@ def test_robot():
 
     env = dict(**os.environ)
 
-    if SERVER_INFO is None:
+    # JUPYTER_LIBRARY_* env vars documentation:
+    # https://robotframework-jupyterlibrary.readthedocs.io/en/stable/LIMITS.html#notebookapp-vs-serverapp
+    if JUPYTER_SERVER_INFO is None:
         env.update(
             JUPYTER_LIBRARY_APP_COMMAND="jupyter-notebook",
             JUPYTER_LIBRARY_APP="NotebookApp",