Skip to content

Adjust HTML table style (GH2209) #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2017

Conversation

jorisvandenbossche
Copy link
Contributor

Closes #2209

@ellisonbg I now set line-height, white-space and max-width to new values. But I think, I could also remove those lines since they are the default values anyway.

@jorisvandenbossche
Copy link
Contributor Author

Regarding line-height / padding.

Current master:

screenshot from 2017-02-26 12-25-29

With this PR, it set line-height from 1.0 to 'normal', because otherwise multi-line cells looked weird (see the issue), but that also causes a normal table without wrapped cells look much more spacious (on my laptop: text is 20px height with 2x 6px padding -> 32 px):

screenshot from 2017-02-26 12-23-45

If I adjust padding from 0.5 to 0.3, it becomes more similar to master (same text height of 20px but with 2x 3.6px padding -> 27.2 px):

screenshot from 2017-02-26 12-38-57

On master it has a text line height of 12 px, with padding of 2x 6px, giving 24px in total.

@ellisonbg
Copy link
Contributor

Thanks! Merging...

@ellisonbg ellisonbg merged commit 2472e89 into jupyter:master Feb 26, 2017
@jorisvandenbossche
Copy link
Contributor Author

@ellisonbg Thanks for merging!

I personally like the one above with a bit less padding (third figure) to have it more similar with master before this PR (first picture), but that is more a matter of personal taste, so leave that decision up to you :-)
(and I think such small adjustments can always be made after in a next small release after using it a bit more in practice?)

@takluyver
Copy link
Member

Yep, I think it's totally fine to make adjustments in 5.1

@takluyver takluyver added this to the 5.0 milestone Jan 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New table style makes it impossible to view data (5.0 beta)
3 participants