Merge pull request #1506 from blink1073/remove-lab

Remove hard-coded JupyterLab in favor of a server extension

Author: jasongrout

notebook/lab/__init__.py

@@ -270,7 +270,6 @@ def init_handlers(self, settings):
         handlers.extend(load_handlers('services.nbconvert.handlers'))
         handlers.extend(load_handlers('services.kernelspecs.handlers'))
         handlers.extend(load_handlers('services.security.handlers'))
-        handlers.extend(load_handlers('lab.handlers'))
 
         # BEGIN HARDCODED WIDGETS HACK
         # TODO: Remove on notebook 5.0

notebook/lab/handlers.py

@@ -129,9 +129,6 @@ def find_package_data():
         pjoin('static', 'services', 'built', '*contents.js'),
         pjoin('static', 'services', 'built', '*contents.js.map'),
     ])
-    
-    # Add the Lab page contents
-    static_data.append(pjoin('lab', 'build', '*'))
 
     components = pjoin("static", "components")
     # select the components we actually need to install
@@ -217,9 +214,7 @@ def check_package_data(package_data):
         pkg_root = pjoin(*pkg.split('.'))
         for d in data:
             path = pjoin(pkg_root, d)
-            if 'lab/build' in path:  # Do not verify lab install yet
-                continue
-            elif '*' in path:
+            if '*' in path:
                 assert len(glob(path)) > 0, "No files match pattern %s" % path
             else:
                 assert os.path.exists(path), "Missing package data: %s" % path
@@ -365,7 +360,6 @@ def finalize_options(self):
 
     bower_dir = pjoin(static, 'components')
     node_modules = pjoin(repo_root, 'node_modules')
-    lab_dir = pjoin(repo_root, 'notebook', 'lab')
 
     def run(self):
         npm_install(repo_root)
@@ -377,12 +371,6 @@ def run(self):
             print("You can install js dependencies with `npm install`", file=sys.stderr)
             raise
 
-        try:
-            npm_install(self.lab_dir)
-            run(['npm', 'run', 'build'], cwd=self.lab_dir)
-        except Exception as e:
-            print("Failed to install JupyterLab`: %s" % e, file=sys.stderr)
-
         # update package data in case this created new files
         update_package_data(self.distribution)