Fix pybind11 deprecation warnings #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
fix_warnings
branch
from
9fae51a to
7d8ac01
Compare
|
Hum, too bad it is deprecated. I found the previous API simpler. How about we keep the previous API call in a comment, and ask upstream if they would be OK de-deprecating it. |
|
I agree, I opened a PR simplifying it a bit: pybind/pybind11#2717 |
|
Ah, I was opening pybind/pybind11#2718 at the same time. |
martinRenou
force-pushed
the
fix_warnings
branch
from
7d8ac01 to
9fda0dc
Compare
src/xinternal_utils.cpp
Outdated
| @@ -32,6 +32,11 @@ namespace nl = nlohmann; | |||
|
|
|||
| namespace xpyt | |||
| { | |||
| py::module create_module(const std::string& module_name) | |||
| { | |||
| return py::module_::create_extension_module(module_name, nullptr, new py::module_::module_def); | |||
There was a problem hiding this comment.
should be
return py::module_::create_extension_module(module_name.c_str(), nullptr, new py::module_::module_def);
Signed-off-by: martinRenou <[email protected]>
martinRenou
force-pushed
the
fix_warnings
branch
from
9fda0dc to
250f055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #365