Fix a case where AssignmentExpression is deeply nested

This commit also refactor `inConstructor` function from `prop-types`
rule into `utils/Components` so that another rule could use that logic
as well.

Author: lukyth

lib/rules/prop-types.js

@@ -62,21 +62,6 @@ module.exports = {
 
     const MISSING_MESSAGE = '\'{{name}}\' is missing in props validation';
 
-    /**
-     * Check if we are in a class constructor
-     * @return {boolean} true if we are in a class constructor, false if not
-     */
-    function inConstructor() {
-      let scope = context.getScope();
-      while (scope) {
-        if (scope.block && scope.block.parent && scope.block.parent.kind === 'constructor') {
-          return true;
-        }
-        scope = scope.upper;
-      }
-      return false;
-    }
-
     /**
      * Check if we are in a class constructor
      * @return {boolean} true if we are in a class constructor, false if not
@@ -290,7 +275,7 @@ module.exports = {
     function getPropertyName(node) {
       const isDirectProp = DIRECT_PROPS_REGEX.test(sourceCode.getText(node));
       const isInClassComponent = utils.getParentES6Component() || utils.getParentES5Component();
-      const isNotInConstructor = !inConstructor();
+      const isNotInConstructor = !utils.inConstructor();
       const isNotInComponentWillReceiveProps = !inComponentWillReceiveProps();
       const isNotInShouldComponentUpdate = !inShouldComponentUpdate();
       if (isDirectProp && isInClassComponent && isNotInConstructor && isNotInComponentWillReceiveProps
@@ -382,7 +367,7 @@ module.exports = {
             // let {firstname} = props
             const directDestructuring =
               PROPS_REGEX.test(node.init.name) &&
-              (utils.getParentStatelessComponent() || inConstructor() || inComponentWillReceiveProps())
+              (utils.getParentStatelessComponent() || utils.inConstructor() || inComponentWillReceiveProps())
             ;
 
             if (thisDestructuring) {
@@ -416,7 +401,7 @@ module.exports = {
             name: name,
             allNames: allNames,
             node: (
-              !isDirectProp && !inConstructor() && !inComponentWillReceiveProps() ?
+              !isDirectProp && !utils.inConstructor() && !inComponentWillReceiveProps() ?
                 node.parent.property :
                 node.property
             )
@@ -502,7 +487,7 @@ module.exports = {
         const directDestructuring =
           destructuring &&
           PROPS_REGEX.test(node.init.name) &&
-          (utils.getParentStatelessComponent() || inConstructor() || inComponentWillReceiveProps())
+          (utils.getParentStatelessComponent() || utils.inConstructor() || inComponentWillReceiveProps())
         ;
 
         if (!thisDestructuring && !directDestructuring) {

lib/rules/state-in-constructor.js

@@ -32,7 +32,7 @@ module.exports = {
           option === 'always' &&
           !node.static &&
           node.key.name === 'state' &&
-          utils.isES6Component(node.parent.parent)
+          utils.getParentES6Component()
         ) {
           context.report({
             node,
@@ -45,8 +45,8 @@ module.exports = {
           option === 'never' &&
           node.left.object.type === 'ThisExpression' &&
           node.left.property.name === 'state' &&
-          node.parent.parent.parent.parent.kind === 'constructor' &&
-          utils.isES6Component(node.parent.parent.parent.parent.parent.parent)
+          utils.inConstructor() &&
+          utils.getParentES6Component()
         ) {
           context.report({
             node,

lib/util/Components.js

@@ -306,6 +306,21 @@ function componentRule(rule, context) {
       return calledOnReact;
     },
 
+    /**
+     * Check if we are in a class constructor
+     * @return {boolean} true if we are in a class constructor, false if not
+     */
+    inConstructor: function() {
+      let scope = context.getScope();
+      while (scope) {
+        if (scope.block && scope.block.parent && scope.block.parent.kind === 'constructor') {
+          return true;
+        }
+        scope = scope.upper;
+      }
+      return false;
+    },
+
     getReturnPropertyAndNode(ASTnode) {
       let property;
       let node = ASTnode;

tests/lib/rules/state-in-constructor.js

@@ -184,6 +184,20 @@ ruleTester.run('state-in-constructor', rule, {
       }
     `,
     options: ['never']
+  }, {
+    code: `
+      class Foo extends React.Component {
+        constructor(props) {
+          super(props)
+          if (foobar) {
+            this.state = { bar: 0 }
+          }
+        }
+        render() {
+          return <div>Foo</div>
+        }
+      }
+    `
   }],
 
   invalid: [{
@@ -293,5 +307,23 @@ ruleTester.run('state-in-constructor', rule, {
     errors: [{
       message: 'State initialization should be in a class property'
     }]
+  }, {
+    code: `
+      class Foo extends React.Component {
+        constructor(props) {
+          super(props)
+          if (foobar) {
+            this.state = { bar: 0 }
+          }
+        }
+        render() {
+          return <div>Foo</div>
+        }
+      }
+    `,
+    options: ['never'],
+    errors: [{
+      message: 'State initialization should be in a class property'
+    }]
   }]
 });